[PATCH] base-sim: remove unused wait_for_unlock_id in SendPinPukContext

Aleksander Morgado aleksander at aleksander.es
Mon Jul 3 08:38:55 UTC 2017


On 01/07/17 05:00, Ben Chan wrote:
> Commit d27e40ae9 ("core: new `Initializing' state in the global modem
> state machine") added a 'wait_for_unlock_id' field to SendPinPukContext,
> but never actually set it up.

Good catch :) pushed to git master, thanks.

> ---
>  src/mm-base-sim.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c
> index 6a790916..fdd9ee14 100644
> --- a/src/mm-base-sim.c
> +++ b/src/mm-base-sim.c
> @@ -505,15 +505,11 @@ typedef struct {
>      MMBaseSim *self;
>      GSimpleAsyncResult *result;
>      GError *save_error;
> -    gulong wait_for_unlock_id;
>  } SendPinPukContext;
>  
>  static void
>  send_pin_puk_context_complete_and_free (SendPinPukContext *ctx)
>  {
> -    if (ctx->wait_for_unlock_id)
> -        g_signal_handler_disconnect (ctx->self->priv->modem,
> -                                     ctx->wait_for_unlock_id);
>      if (ctx->save_error)
>          g_error_free (ctx->save_error);
>      g_simple_async_result_complete (ctx->result);
> 


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list