[PATCH 5/5] modem-helpers: minor coding style fixes

Aleksander Morgado aleksander at aleksander.es
Fri Jul 14 09:01:04 UTC 2017


On 14/07/17 10:06, Ben Chan wrote:
> ---
>  src/mm-modem-helpers.c         | 6 +++---
>  src/mm-modem-helpers.h         | 6 +++---
>  src/tests/test-modem-helpers.c | 4 ++--
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 

Pushed to git master, thanks.

> diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c
> index 5e257a87..3af3f2d5 100644
> --- a/src/mm-modem-helpers.c
> +++ b/src/mm-modem-helpers.c
> @@ -2619,7 +2619,7 @@ mm_3gpp_parse_cpms_query_response (const gchar *reply,
>  
>      r = g_regex_new (CPMS_QUERY_REGEX, G_REGEX_RAW, 0, NULL);
>  
> -    g_assert(r);
> +    g_assert (r);
>  
>      if (!g_regex_match (r, reply, 0, &match_info)) {
>          g_set_error (error, MM_CORE_ERROR, MM_CORE_ERROR_FAILED,
> @@ -2627,7 +2627,7 @@ mm_3gpp_parse_cpms_query_response (const gchar *reply,
>          goto end;
>      }
>  
> -    if (!g_match_info_matches(match_info)) {
> +    if (!g_match_info_matches (match_info)) {
>          g_set_error (error, MM_CORE_ERROR, MM_CORE_ERROR_FAILED,
>                       "Could not find matches in CPMS query reply '%s'", reply);
>          goto end;
> @@ -2662,7 +2662,7 @@ mm_3gpp_get_cpms_storage_match (GMatchInfo *match_info,
>      gboolean ret = TRUE;
>      gchar *str = NULL;
>  
> -    str = g_match_info_fetch_named(match_info, match_name);
> +    str = g_match_info_fetch_named (match_info, match_name);
>      if (str == NULL || str[0] == '\0') {
>          g_set_error (error, MM_CORE_ERROR, MM_CORE_ERROR_FAILED,
>                       "Could not find '%s' from CPMS reply", match_name);
> diff --git a/src/mm-modem-helpers.h b/src/mm-modem-helpers.h
> index ab566539..5abaffd7 100644
> --- a/src/mm-modem-helpers.h
> +++ b/src/mm-modem-helpers.h
> @@ -91,9 +91,9 @@ GArray *mm_filter_supported_capabilities (MMModemCapability all,
>  /*****************************************************************************/
>  /* VOICE specific helpers and utilities */
>  /*****************************************************************************/
> -GRegex *mm_voice_ring_regex_get (void);
> -GRegex *mm_voice_cring_regex_get(void);
> -GRegex *mm_voice_clip_regex_get (void);
> +GRegex *mm_voice_ring_regex_get  (void);
> +GRegex *mm_voice_cring_regex_get (void);
> +GRegex *mm_voice_clip_regex_get  (void);
>  
>  /*****************************************************************************/
>  /* SERIAL specific helpers and utilities */
> diff --git a/src/tests/test-modem-helpers.c b/src/tests/test-modem-helpers.c
> index 5fdded4a..e0e15ebd 100644
> --- a/src/tests/test-modem-helpers.c
> +++ b/src/tests/test-modem-helpers.c
> @@ -2674,7 +2674,7 @@ test_cpms_query_response (void *f, gpointer d) {
>                                                   &mem1,
>                                                   &mem2,
>                                                   &error);
> -        g_assert(ret);
> +        g_assert (ret);
>          g_assert_no_error (error);
>          g_assert_cmpuint (cpms_query_test[i].mem1_want, ==, mem1);
>          g_assert_cmpuint (cpms_query_test[i].mem2_want, ==, mem2);
> @@ -3297,7 +3297,7 @@ test_crsm_response (void)
>  
>          g_assert_cmpstr (crsm_tests[i].hex, ==, hex);
>  
> -        g_free(hex);
> +        g_free (hex);
>      }
>  }
>  
> 


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list