[review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

[Ben Chan]

On Sun, Jul 16, 2017 at 11:03 PM, Ben Chan <benchan at chromium.org> wrote:
> This branch contains a series of patches that port
> MMBroadbandModemMbim to use GTask:
>
> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem

Aleksander,

Just realized there may be an issue with changes to some of those
MMIfaceModem3gpp / MMIfaecModemCdma functions implemented by
MMBroadbandModem. Several plugins have code that chains up parent's
function like this:

   if (!iface_modem_cdma_parent->cleanup_unsolicited_events_finish
(self, res, &error))
           ...
   else
           g_simple_async_result_set_op_res_gboolean
(G_SIMPLE_ASYNC_RESULT (res), TRUE);

which will need some rework. I'll take out those related patches from
my branch for now.

>
> Ben