[PATCH 2/3] iface-modem-time: fix update_network_timezone to use g_task_report_new_error
Ben Chan
benchan at chromium.org
Tue Jul 18 01:11:00 UTC 2017
Commit 7c5f308af ("iface-modem-time: port update_network_timezone to use
GTask") ported most of the update_network_timezone code to use GTask,
but missed a g_simple_async_report_error_in_idle call, which could
potentially lead to an incorrect G_TASK cast.
---
src/mm-iface-modem-time.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c
index 41ca2f0e..f0c1fea6 100644
--- a/src/mm-iface-modem-time.c
+++ b/src/mm-iface-modem-time.c
@@ -327,12 +327,13 @@ update_network_timezone (MMIfaceModemTime *self,
/* If loading network timezone not supported, just finish here */
if (!MM_IFACE_MODEM_TIME_GET_INTERFACE (self)->load_network_timezone ||
!MM_IFACE_MODEM_TIME_GET_INTERFACE (self)->load_network_timezone_finish) {
- g_simple_async_report_error_in_idle (G_OBJECT (self),
- callback,
- user_data,
- MM_CORE_ERROR,
- MM_CORE_ERROR_UNSUPPORTED,
- "Loading network timezone is not supported");
+ g_task_report_new_error (self,
+ callback,
+ user_data,
+ update_network_timezone,
+ MM_CORE_ERROR,
+ MM_CORE_ERROR_UNSUPPORTED,
+ "Loading network timezone is not supported");
return;
}
--
2.13.2.932.g7449e964c-goog
More information about the ModemManager-devel
mailing list