[PATCH] telit: fix modem_set_current_bands to use g_task_report_new_error

Ben Chan benchan at chromium.org
Tue Jul 18 08:47:03 UTC 2017


On Tue, Jul 18, 2017 at 1:34 AM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> On 18/07/17 10:27, Aleksander Morgado wrote:
>> -        g_simple_async_report_error_in_idle (G_OBJECT (self),
>> -                                             callback,
>> -                                             user_data,
>> -                                             MM_CORE_ERROR,
>> -                                             MM_CORE_ERROR_FAILED,
>> -                                             "Unexpectd error: could not compose AT#BND command");
>> +        g_task_report_new_error (self,
>> +                                 callback,
>> +                                 user_data,
>> +                                 MM_CORE_ERROR,
>> +                                 MM_CORE_ERROR_FAILED,
>> +                                 "Unexpectd error: could not compose AT#BND command");
>>          return;
>
> Oops, I pushed without compiling and just found out that the "source_tag" parameter was missing in this g_task_report_new_error() call. Pushed a follow-up fix for that.

Oops, my bad. Perhaps I compiled a wrong branch and didn't catch the mistake.

>
> --
> Aleksander
> https://aleksander.es


More information about the ModemManager-devel mailing list