Start-up stalls getting own number

[Aleksander Morgado]

On Wed, Jul 19, 2017 at 11:00 AM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> On Wed, Jul 19, 2017 at 10:26 AM, Colin Helliwell
> <colin.helliwell at ln-systems.com> wrote:
>> Just trying out this morning's Head revision, and it seems to be stalling at the point it's trying to read its own number.
>> mmcli -L reports no modems, and the logs ends with (i.e. there's no further messages at all):
>>
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.141518] [src/mm-broadband-modem.c:1199] modem_load_own_numbers(): loading own numbers...
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.141858] [src/mm-port-serial.c:1252] mm_port_serial_open(): (ttyMux1) device open count is 3 (open)
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.142265] [src/mm-port-serial.c:1309] _close_internal(): (ttyMux1) device open count is 2 (close)
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.142631] [src/mm-port-serial-at.c:463] debug_log(): (ttyMux1): --> 'AT+CNUM<CR>'
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.176295] [src/mm-port-serial-at.c:463] debug_log(): (ttyMux1): <-- '<CR><LF>OK<CR><LF>'
>> Jul 19 09:19:19 wg daemon.debug ModemManager[830]: <debug> [1500452359.176799] [src/mm-port-serial.c:1309] _close_internal(): (ttyMux1) device open count is 1 (close)
>>
>> The SIM in question doesn't have its number stored on it; I tried one which does and that one intializes ok.
>
> Yep, this seems  a bug from the recent GTask migration; if CNUM
> returns with an empty string and we cannot parse it into an array of
> numbers we're not completing the task:
>
>         numbers = mm_3gpp_parse_cnum_exec_response (result, &error);
>         if (numbers)
>             g_task_return_pointer (task, numbers, (GDestroyNotify)g_strfreev);
>         // else missing here returning a NULL pointer
>
> Will get that fixed
>

Could you test the attached patch?

-- 
Aleksander
https://aleksander.es
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-broadband-modem-if-no-own-numbers-returned-complete-.patch
Type: text/x-patch
Size: 876 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20170719/60678851/attachment.bin>