[PATCH] broadband-bearer: fix crm_range_ready

Aleksander Morgado aleksander at aleksander.es
Wed Jul 19 12:00:08 UTC 2017


On Wed, Jul 19, 2017 at 12:28 AM, Ben Chan <benchan at chromium.org> wrote:
> crm_range_ready() misses a return statement after it invokes
> interface_initialization_step(), which will lead to an invalid access of
> the already freed InitAsyncContext.
> ---
>  src/mm-broadband-bearer.c | 1 +
>  1 file changed, 1 insertion(+)
>

Nice catch! Pushed to git master, mm-1-6, mm-1-4 and mm-1-2.

> diff --git a/src/mm-broadband-bearer.c b/src/mm-broadband-bearer.c
> index 696f9bfd..a2bcb3a4 100644
> --- a/src/mm-broadband-bearer.c
> +++ b/src/mm-broadband-bearer.c
> @@ -2210,6 +2210,7 @@ crm_range_ready (MMBaseModem *modem,
>                  /* Fine, go on with next step */
>                  ctx->step++;
>                  interface_initialization_step (ctx);
> +                return;
>              }
>
>              g_assert (error == NULL);
> --
> 2.13.2.932.g7449e964c-goog
>



-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list