[PATCH] broadband-bearer: run init sequence after flashing in disconnection

[Dan Williams]

On Tue, 2017-07-25 at 14:31 +0100, Tim Small wrote:
> On 25/07/17 13:48, Aleksander Morgado wrote:
> > What do you think of this change? It should clear up the mixup of
> > commands sent while flashing is ongoing.
> 
> Hi Aleksander,
> 
> That patch looks reasonable, with the caveat that I don't have my
> head
> around the code base at all :-).
> 
> It appears to do the job in limited testing:
> 
> 56.227702] Flashing data port (ttyUSB0)...
> 56.227879] (ttyUSB0): port attributes not fully set
> 57.228965] (ttyUSB0): disabling RTS/CTS flow control
> 57.229207] (ttyUSB0) device open count is 2 (close)
> 57.229237] (ttyUSB0): running init sequence...
> 57.229262] Sending PDP context deactivation in primary/data port...
> 57.229286] (ttyUSB0) device open count is 3 (open)
> 57.229311] (ttyUSB0): --> 'ATE0<CR>'

There's a couple more things we could do with the disconnect code too.

As you suggest, we could set AT&D<something> by default and if the
modem allows that, hope that dropping DTR does the right thing.

Or if the modem doesn't, we could send the breaks.  If the modem
doesn't actually drop to command mode (&D1) then we could also send
breaks.

It's all a bit icky, this is why the multiple interface with ethernet
port is nice :)

Dan