[PATCH] log: fix WITH_SYSTEMD_JOURNAL guards

Aleksander Morgado aleksander at aleksander.es
Thu Jun 22 08:24:44 UTC 2017


Hey,

On Thu, Jun 22, 2017 at 8:59 AM, Ben Chan <benchan at chromium.org> wrote:
> BTW, those WITH_* guards in ModemManager seem a bit inconsistent.
>
> WITH_QMI, WITH_MBIM is only defined as 1 when enabled. The code has a mixed
> use of `#if WITH_XXX` and `#if defined WITH_XXX` for them.  Other WITH_* is
> defined to be either 0 or 1, and the code uses `#if WITH_XXX`.  Should we
> settle with one style?
>

Yes, let's consolidate those. I'll push fixes to solve that.


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list