[PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled

Colin Helliwell colin.helliwell at ln-systems.com
Thu Jun 22 15:51:18 UTC 2017


> On 22 June 2017 at 16:39 Aleksander Morgado <aleksander at aleksander.es> wrote:
> 
> On Thu, Jun 22, 2017 at 3:56 PM, Colin Helliwell
> 
> <colin.helliwell at ln-systems.com> wrote:
> 
> > I think this is broken (along the lines of Ben's #if/#ifdef question).
> > Configuring with --with-systemd-journal results in
> > 
> > #define WITH_SYSTEMD_JOURNAL 0
> > in config.h, but the code (e.g. mm-log.c) is using a '#if defined' ?
> 
> Are you sure? did you do a clean build? There's no place in configure,
> with the patch applied, where WITH_SYSTEMD_JOURNAL is set to 0...
> 

Ah sorry, just realised I misread your patch email - I saw similar in the git log and assumed they were one-in-the-same, whereas yours *removes* that!


More information about the ModemManager-devel mailing list