[PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled

[Aleksander Morgado]

On Thu, Jun 22, 2017 at 6:28 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
>>> > I think this is broken (along the lines of Ben's #if/#ifdef question).
>>> > Configuring with --with-systemd-journal results in
>>> >
>>> > #define WITH_SYSTEMD_JOURNAL 0
>>> > in config.h, but the code (e.g. mm-log.c) is using a '#if defined' ?
>>>
>>> Are you sure? did you do a clean build? There's no place in configure,
>>> with the patch applied, where WITH_SYSTEMD_JOURNAL is set to 0...
>>>
>>
>> Ah sorry, just realised I misread your patch email - I saw similar in the git log and assumed they were one-in-the-same, whereas yours *removes* that!
>
> Yes, this patch is basically the opposite approach to Ben's patch;
> instead of assuming the symbol is always defined, this patch defines
> it only when the feature enabled.

BTW; even if the misread happened, thank you very much for reviewing
the patch :)

-- 
Aleksander
https://aleksander.es