[PATCH] cinterion: improve ^SCFG=? response parser to handle EHS5 format

[Aleksander Morgado]

On Tue, Mar 7, 2017 at 6:39 PM, Colin Helliwell
<colin.helliwell at ln-systems.com> wrote:
>
>> On 07 March 2017 at 16:44 Aleksander Morgado <aleksander at aleksander.es> wrote:
>>
>> Two main changes in the regex:
>>
>> *   Ignore double quotes around interval numbers.
>> *   Ignore second set of values (i.e. the one after the comma), as it
>> may not even be given).
>>
>> We now support at least these two formats:
>>  ^SCFG: "Radio/Band",("1-511","0-1")
>>  ^SCFG: "Radio/Band\",("1"-"147")
>>
>> Reported-by: Colin Helliwell <colin.helliwell at ln-systems.com>
>>
>> ---
>>
>> Hey Colin,
>>
>> Could you test this patch in a real run? I added a new unit test, but would like to confirm that it works for you before pushing.
>>
>> Cheers!
>>
>
> Yep, I think that's got it:
>
> /org/freedesktop/ModemManager1/Modem/0 (device id 'df573c02e8b5ba34f5716b725e0894f800aac1af')
>   -------------------------
>   Hardware |   manufacturer: 'Cinterion'
>            |          model: 'EHS5-E'
>            |       revision: 'REVISION 03.001'
>            |      supported: 'gsm-umts'
>            |        current: 'gsm-umts'
>            |   equipment id: '357049999996888'
>   -------------------------
>   System   |         device: 'LinMux'
>            |        drivers: 'linmux'
>            |         plugin: 'Cinterion'
>            |   primary port: 'ttyMux0'
>            |          ports: 'ttyMux0 (at), ttyMux1 (at)'
>   -------------------------
>   Numbers  |           own : 'unknown'
>   -------------------------
>   Status   |           lock: 'none'
>            | unlock retries: 'unknown'
>            |          state: 'disabled'
>            |    power state: 'on'
>            |    access tech: 'unknown'
>            | signal quality: '0' (cached)
>   -------------------------
>   Modes    |      supported: 'allowed: any; preferred: none'
>            |        current: 'allowed: any; preferred: none'
>   -------------------------
>   Bands    |      supported: 'egsm, dcs, u2100, u900'
>            |        current: 'egsm, dcs, u2100, u900'
>   -------------------------
>   IP       |      supported: 'ipv4, ipv6, ipv4v6'
>   -------------------------
>   3GPP     |           imei: '357870011454321'
>            |  enabled locks: 'none'
>            |    operator id: 'unknown'
>            |  operator name: 'unknown'
>            |   subscription: 'unknown'
>            |   registration: 'unknown'
>   -------------------------
>   SIM      |           path: '/org/freedesktop/ModemManager1/SIM/0'
>
>   -------------------------
>   Bearers  |          paths: 'none'

Thanks, pushed to git master as well as mm-1-6 and mm-1-4.

-- 
Aleksander
https://aleksander.es