[PATCH] base-bearer: stop connection status monitoring if no TTY available

Aleksander Morgado aleksander at aleksander.es
Fri Mar 24 20:52:15 UTC 2017


On 24/03/17 21:20, Aleksander Morgado wrote:
>>> +    /* If CID not defined, error out */
>>>      if (!MM_BROADBAND_BEARER (self)->priv->cid) {
>>> -        g_task_return_new_error (task, MM_CORE_ERROR,
>>> MM_CORE_ERROR_FAILED,
>>> +        g_task_return_new_error (task, MM_CORE_ERROR,
>>> MM_CORE_ERROR_UNSUPPORTED,
>> Did you mean to change this case from FAILED -> UNSUPPORTED?
> Yes, but on a second thought, you're right, that should be kept
> FAILED. I'll update it.

Pushed to git master after updating that specific error back to FAILED,
and also the error string returned when no available TTY was found,
which was also incorrect.

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list