[PATCH 4/8] telit: ignore custom flow control handling

Aleksander Morgado aleksander at aleksander.es
Sat Mar 25 18:32:13 UTC 2017


The generic modem object already supports querying for the supported
methods and setting the best one found.
---
 plugins/telit/mm-broadband-modem-telit.c | 48 --------------------------------
 1 file changed, 48 deletions(-)

diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c
index 6ef340f1..d63cb0aa 100644
--- a/plugins/telit/mm-broadband-modem-telit.c
+++ b/plugins/telit/mm-broadband-modem-telit.c
@@ -885,52 +885,6 @@ load_access_technologies (MMIfaceModem *self,
 }
 
 /*****************************************************************************/
-/* Flow control (Modem interface) */
-
-static gboolean
-setup_flow_control_finish (MMIfaceModem *self,
-                           GAsyncResult *res,
-                           GError **error)
-{
-    /* Completely ignore errors */
-    return TRUE;
-}
-
-static void
-setup_flow_control (MMIfaceModem *self,
-                    GAsyncReadyCallback callback,
-                    gpointer user_data)
-{
-    GSimpleAsyncResult *result;
-    gchar *cmd;
-    guint flow_control = 1; /* Default flow control: XON/XOFF */
-
-    switch (mm_base_modem_get_product_id (MM_BASE_MODEM (self)) & 0xFFFF) {
-    case 0x0021:
-        flow_control = 2; /* Telit IMC modems support only RTS/CTS mode */
-        break;
-    default:
-        break;
-    }
-
-    cmd = g_strdup_printf ("+IFC=%u,%u", flow_control, flow_control);
-    mm_base_modem_at_command (MM_BASE_MODEM (self),
-                              cmd,
-                              3,
-                              FALSE,
-                              NULL,
-                              NULL);
-    result = g_simple_async_result_new (G_OBJECT (self),
-                                        callback,
-                                        user_data,
-                                        setup_flow_control);
-    g_simple_async_result_set_op_res_gboolean (result, TRUE);
-    g_simple_async_result_complete_in_idle (result);
-    g_object_unref (result);
-    g_free (cmd);
-}
-
-/*****************************************************************************/
 /* Load current mode (Modem interface) */
 
 static gboolean
@@ -1287,8 +1241,6 @@ iface_modem_init (MMIfaceModem *iface)
     iface->modem_power_down_finish = modem_power_down_finish;
     iface->load_access_technologies = load_access_technologies;
     iface->load_access_technologies_finish = load_access_technologies_finish;
-    iface->setup_flow_control = setup_flow_control;
-    iface->setup_flow_control_finish = setup_flow_control_finish;
     iface->load_supported_modes = load_supported_modes;
     iface->load_supported_modes_finish = load_supported_modes_finish;
     iface->load_current_modes = load_current_modes;
-- 
2.12.0



More information about the ModemManager-devel mailing list