huawei: duplicated DTMF tone

[Riccardo Vangelisti]

Hi all,
I've found a strange behavior when I receive DTMF during voice call.
It seems that DTMF code are received and signaled twice, specifically 
one time for each active AT port.

Jan  1 00:02:22 localhost ModemManager[1940]: <debug> 
[1325376142.982264] [mm-port-serial-at.c:459] debug_log(): (ttyUSB0): 
<-- '<CR><LF>^DDTMF: 9<CR><LF>'
Jan  1 00:02:22 localhost ModemManager[1940]: <debug> 
[1325376142.982562] [huawei/mm-broadband-modem-huawei.c:3051] 
huawei_voice_received_dtmf(): [^DDTMF] Received DTMF '9'
Jan  1 00:02:22 localhost ModemManager[1940]: <debug> 
[1325376142.983283] [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): 
<-- '<CR><LF>^DDTMF: 9<CR><LF>'
Jan  1 00:02:22 localhost ModemManager[1940]: <debug> 
[1325376142.983596] [huawei/mm-broadband-modem-huawei.c:3051] 
huawei_voice_received_dtmf(): [^DDTMF] Received DTMF '9'


# dbus-monitor --system

signal sender=:1.0 -> dest=(null destination) serial=1362 
path=/org/freedesktop/ModemManager1/Call/1; 
interface=org.freedesktop.ModemManager1.Call; member=DtmfReceived
    string "9"
signal sender=:1.0 -> dest=(null destination) serial=1363 
path=/org/freedesktop/ModemManager1/Call/1; 
interface=org.freedesktop.ModemManager1.Call; member=DtmfReceived
    string "9"


Looking in commit log, I've found that problem is present since this 
commit: "huawei: update to correct secondary port request and regex 
masking for ^POSITION" (1f270c09d03b6c2c4c57fb9b8ca539243035992b)
This commit enable all unsolicited message (DTMF included) also on 
secondary AT port.

In most cases unsolicited message can be handled twice or many times 
without any side effect, but in the case of voice command (DTMF, call, 
ecc...) this is a problem.

Reverting to the previous behavior (unsolicited message handled only on 
primary AT port) DTMF are received correctly but there is a CPU loading 
issue as reported by Marc Murphy (and verified by me).

Is this right ? Any ideas ?

Thanks,
Riccardo