[review] dcbw/huawei-voice

[Aleksander Morgado]

On Fri, May 5, 2017 at 6:56 PM, Riccardo Vangelisti
<riccardo.vangelisti at sadel.it> wrote:
>> I would suggest ID_MM_VOICE_SUPPORTED=1 or something like that, and
>> make it available to all devices not just Huawei.
>
> Perfect !

Also agree on this, yes.

>>
>>
>> The next question is whether these devices should provide anything in
>> the "Audio Format" and "Audio Port" properties.  I would say no, since
>> it's very hardware specific and not generally applicable.
>
> Ok, I would suggest "Audio Port" something like "forced" or "User request"
> if voice was enabled by udev tags and all "Audio Format" fields set to
> unknown.

How about "external" for audio port and audio format "n/a" or
something like that?

>>
>>
>> So I will modify the branch to add the ID_MM_VOICE_SUPPORTED tag, and
>> have that override the CVOICE check in the Huawei plugin.  I just don't
>> want MM to say "this modem supports voice!" for a device that clearly
>> has no way to get voice out (like many USB sticks).  I think the
>> combination of udev tags and plugin-specific probing would make us all
>> happy.
>>
>> What do you think?
>
> Ok, it's correct.

Agree.


-- 
Aleksander
https://aleksander.es