[PATCH] udev: remove default ID_MM_PLATFORM_DRIVER_PROBE whitelist

Aleksander Morgado aleksander at aleksander.es
Thu May 18 08:15:19 UTC 2017


The whitelist made all platform TTYs managed by the 'atmel_usart'
kernel driver probed by ModemManager, which isn't something we want,
as most of these aren't broadband modems.

We leave the logic supporting the ID_MM_PLATFORM_DRIVER_PROBE udev tag
as there may be a case where the user does need ModemManager to probe
a given platform TTY.
---

Hey Dan,

>From my understanding, I believe we don't want to automatically probe all platform ports exposed via the 'atmel_usart' driver.

Looking at the attribute walk you sent me yesterday, I fail to see how the PCMCIA device would be tagged with ID_MM_PLATFORM_DRIVER_PROBE, so maybe this is something that was required in the past and now it's no longer needed?

Let me know what you think.

---
 src/77-mm-platform-serial-whitelist.rules | 13 -------------
 src/Makefile.am                           |  1 -
 2 files changed, 14 deletions(-)
 delete mode 100644 src/77-mm-platform-serial-whitelist.rules

diff --git a/src/77-mm-platform-serial-whitelist.rules b/src/77-mm-platform-serial-whitelist.rules
deleted file mode 100644
index faf4472b..00000000
--- a/src/77-mm-platform-serial-whitelist.rules
+++ /dev/null
@@ -1,13 +0,0 @@
-# do not edit this file, it will be overwritten on update
-
-ACTION!="add|change|move", GOTO="mm_platform_device_whitelist_end"
-SUBSYSTEM!="platform", GOTO="mm_platform_device_whitelist_end"
-
-# Be careful here since many devices connected to platform drivers on PCs
-# are legacy devices that won't like probing.  But often on embedded
-# systems serial ports are provided by platform devices.
-
-# Allow atmel_usart
-DRIVERS=="atmel_usart", ENV{ID_MM_PLATFORM_DRIVER_PROBE}="1"
-
-LABEL="mm_platform_device_whitelist_end"
diff --git a/src/Makefile.am b/src/Makefile.am
index 13481e96..6b29bfe9 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -54,7 +54,6 @@ udevrulesdir = $(UDEV_BASE_DIR)/rules.d
 udevrules_DATA = \
 	77-mm-usb-device-blacklist.rules \
 	77-mm-pcmcia-device-blacklist.rules \
-	77-mm-platform-serial-whitelist.rules \
 	77-mm-usb-serial-adapters-greylist.rules \
 	80-mm-candidate.rules \
 	$(NULL)
--
2.12.2


More information about the ModemManager-devel mailing list