[PATCH] v1: Logging cleanup and systemd journal support

Aleksander Morgado aleksander at aleksander.es
Mon May 22 08:09:54 UTC 2017


Hey,

On Mon, May 22, 2017 at 7:49 AM, Torsten Hilbrich
<torsten.hilbrich at secunet.com> wrote:
> This series of patches is based on the "Logging and --help
> updates" series posted by Aleksander Morgado
> <aleksander at aleksander.es>.
>
> It start with cleaning up some parts of the logging code. The the
> existing logging support (supporting syslog and file-based
> logging) is split into two different functions using a function
> pointer to select them. Then the support for logging using the
> systemd journal is added.
>
> [PATCH 1/5] log: Refactor evaluation of log level
> [PATCH 2/5] log: Refactor log level text output
> [PATCH 3/5] log: Add mapping from glib loglevel to syslog priority
> [PATCH 4/5] log: Introduce function pointer to handle different log
> [PATCH 5/5] log: Add support for journal logging

Great thing; I gave a quick look to all patches and they look very
good, except for some minor coding style issues. Given that they're
based on top of my latest logging changes, I'll get them properly
reviewed once the previous ones are discussed and/or merged.

Thanks!

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list