[PATCH 1/2] log: new --log-func-loc option to enable function location in logs

Colin Helliwell colin.helliwell at ln-systems.com
Mon May 22 08:21:01 UTC 2017


> On 22 May 2017 at 09:14 Aleksander Morgado <aleksander at aleksander.es> wrote:
> 
> Hey,
> 
> On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
> 
> > The --debug output is a bit annoying right now because it includes the
> > function location information by default. This information is most of
> > the times not very useful, so just make it optional under a new
> > command line argument for the daemon.
> 
> After Torsten's patches to include systemd journal support, which
> already allow you to get function location information implicitly if
> needed, I believe we could get rid of this in the default logging all
> together.
> 
> So I'm going to suggest we skip this patch and we just completely
> remove the function location in the default stdout/syslog logging,
> unless someone has a strong opinion against it.
> 

I've stopped using systemd on my platform and, as mentioned, do quite often find the function location useful. But I don't mind patching it back in for myself if the consensus is to remove it for mainstream.


More information about the ModemManager-devel mailing list