[PATCH 3/4] cinterion: remove custom +CMER enabling

Aleksander Morgado aleksander at aleksander.es
Mon May 29 13:02:46 UTC 2017


On 21/05/17 14:54, Aleksander Morgado wrote:
> This is now managed directly in the generic plugin.

This has been merged to git master.

> ---
>  plugins/cinterion/mm-broadband-modem-cinterion.c | 30 ------------------------
>  1 file changed, 30 deletions(-)
> 
> diff --git a/plugins/cinterion/mm-broadband-modem-cinterion.c b/plugins/cinterion/mm-broadband-modem-cinterion.c
> index fc9a3356..d379ec3b 100644
> --- a/plugins/cinterion/mm-broadband-modem-cinterion.c
> +++ b/plugins/cinterion/mm-broadband-modem-cinterion.c
> @@ -84,34 +84,6 @@ struct _MMBroadbandModemCinterionPrivate {
>  };
>  
>  /*****************************************************************************/
> -/* Unsolicited events enabling */
> -
> -static gboolean
> -enable_unsolicited_events_finish (MMIfaceModem3gpp *self,
> -                                  GAsyncResult *res,
> -                                  GError **error)
> -{
> -    return !!mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, error);
> -}
> -
> -static void
> -enable_unsolicited_events (MMIfaceModem3gpp *self,
> -                           GAsyncReadyCallback callback,
> -                           gpointer user_data)
> -{
> -    /* AT=CMER=[<mode>[,<keyp>[,<disp>[,<ind>[,<bfr>]]]]]
> -     *  but <ind> should be either not set, or equal to 0 or 2.
> -     * Enabled with 2.
> -     */
> -    mm_base_modem_at_command (MM_BASE_MODEM (self),
> -                              "+CMER=3,0,0,2",
> -                              3,
> -                              FALSE,
> -                              callback,
> -                              user_data);
> -}
> -
> -/*****************************************************************************/
>  /* Enable unsolicited events (SMS indications) (Messaging interface) */
>  
>  static gboolean
> @@ -1824,8 +1796,6 @@ iface_modem_init (MMIfaceModem *iface)
>  static void
>  iface_modem_3gpp_init (MMIfaceModem3gpp *iface)
>  {
> -    iface->enable_unsolicited_events = enable_unsolicited_events;
> -    iface->enable_unsolicited_events_finish = enable_unsolicited_events_finish;
>      iface->register_in_network = register_in_network;
>      iface->register_in_network_finish = register_in_network_finish;
>  }
> 


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list