[rfc] Propagate manufacturer information from MMKernelDevice to MMBroadbandModem

[Ben Chan]

On Wed, Oct 4, 2017 at 4:51 AM, Bjørn Mork <bjorn at mork.no> wrote:
> Ben Chan <benchan at chromium.org> writes:
>
>> * The few MBIM modems I have report the correct manufacturer through
>> the manufacturer string descriptor, but I suspect some MBIM modems
>> don't.
>
> FWIW, this is true for all the MBIM modems I've used so far too.  Few
> vendors manage to write their name in a consistent way, but I guess that
> is the same regardless of the source.
>

Hi Bjørn, thanks for checking and providing the list :)

> bjorn at miraculix:/var/tmp/usb$ for f in `grep -l 'CDC MBIM' */lsusb.txt`;
do echo -n "$f: "; grep Manu $f; done
> 0bdb:1926/lsusb.txt:   iManufacturer           1 Lenovo
> 1199:68a2/lsusb.txt:   iManufacturer           4 Sierra Wireless,
Incorporated
> 1199:9041/lsusb.txt:   iManufacturer           1 Sierra Wireless,
Incorporated
> 1199:9079/lsusb.txt:   iManufacturer           1 Sierra Wireless,
Incorporated
> 1199:a001/lsusb.txt:   iManufacturer           1 Sierra Wireless Inc.
> 12d1:1446/lsusb.txt:   iManufacturer           4 Huawei Technologies
> 12d1:157d/lsusb.txt:   iManufacturer           1 HUAWEI_MOBILE
> 12d1:15bb/lsusb.txt:   iManufacturer           6 Huawei Technologies Co.,
Ltd.
> 2001:7d01/lsusb.txt:   iManufacturer           9 D-Link,Inc
> 258d:e000/lsusb.txt:   iManufacturer           1 Sequans Communications
>
> What's the "correct" manufacturer, BTW?  Looking over this list, I note
> that the OEM and chipset vendors Ericsson, Intel, Qualcomm and Mediatek
> are all anonymous here.

Yeah, it's hard to tell which one is more "correct".  It's really up to the
OEMs to specify the appropriate USB vendor ID and manufacturer string
descriptor. Some may specify the chipset vendor and some may choose the
module vendor.  Some OEMs simply "rebrand" existing modules with a new
sticker on the modules but keep vendor ID and manufacturer string unchanged.

>
> The USB vendor ID gives a slightly different list, but not necessarily
> more correct:
>
> bjorn at miraculix:/var/tmp/usb$ for f in `grep -l 'CDC MBIM' */lsusb.txt`;
do echo -n "$f: "; grep idVend $f; done
> 0bdb:1926/lsusb.txt:   idVendor           0x0bdb Ericsson Business Mobile
Networks BV
> 1199:68a2/lsusb.txt:   idVendor           0x1199 Sierra Wireless, Inc.
> 1199:9041/lsusb.txt:   idVendor           0x1199 Sierra Wireless, Inc.
> 1199:9079/lsusb.txt:   idVendor           0x1199 Sierra Wireless, Inc.
> 1199:a001/lsusb.txt:   idVendor           0x1199 Sierra Wireless, Inc.
> 12d1:1446/lsusb.txt:   idVendor           0x12d1 Huawei Technologies Co.,
Ltd.
> 12d1:157d/lsusb.txt:   idVendor           0x12d1 Huawei Technologies Co.,
Ltd.
> 12d1:15bb/lsusb.txt:   idVendor           0x12d1 Huawei Technologies Co.,
Ltd.
> 2001:7d01/lsusb.txt:   idVendor           0x2001 D-Link Corp.
> 258d:e000/lsusb.txt:   idVendor           0x258d
>
>
> Bjørn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20171004/467c593c/attachment.html>