[PATCH] wavecom: port to GTask
Aleksander Morgado
aleksander at aleksander.es
Thu Sep 7 12:10:57 UTC 2017
>> if (result.allowed == MM_MODEM_MODE_NONE)
>> - g_simple_async_result_set_error (simple,
>> - MM_CORE_ERROR,
>> - MM_CORE_ERROR_FAILED,
>> - "Unknown mobile station class:
>> '%s'",
>> - response);
>> + g_task_return_new_error (task, MM_CORE_ERROR,
>> MM_CORE_ERROR_FAILED,
>
>
> not sure about the convention, should 'task' and 'MM_CORE_ERROR,
> MM_CORE_ERROR_FAILED' on separate line? otherwise lgtm
>
Not sure I follow a hard rule for this one, truth be told, especially
in the g_set_error() and friends. But looks like we are already doing
the split in most of other places, so let me send a v2 with that
change.
--
Aleksander
https://aleksander.es
More information about the ModemManager-devel
mailing list