[review v2] Voice implementation fixes (with audio channel setup handlers)

[Aleksander Morgado]

>
>
>
> > > The Huawei USB dongles that support voice require a command
> > > (AT^DDSETEX=2) to be executed when the call is established, and
> > > also
> > > need to report which port is being used for audio. In order to
> > > support
> > > that, instead of subclassing all start/accept/hangup methods, I
> > > extended the MMBaseCall class with two new handlers that allow
> > > setting
> > > up and cleaning up the audio channel however the plugin needs it.
> > > Bob,
> > > you could use these two methods for the custom AT commands you
> > > require
> > > for the SIMCom implementation, right?
> >
> > Possibly, yes.  The SimTech (== SIMCom) plugin is using the
> >
> MMBroadbandModemQmi class which means I either need to (1) subclass
> > MMBroadbandModemQmi and mix in AT commands, or (2) use the plugin's
> > AT-only MBroadbandModemSimtech class and add to it.  I'd rather stick
> > with QMI but I don't know how well the modem will cope with it so I
> > need
> > to experiment.
>
> I'd be very curious if the modem supports the QMI Voice service and if
> so, how that interacts with the actual audio ports the modem exposes.
>


Yes, using QMI also for the voice management would be ideal, if the device
supports the VOICE service. Otherwise, falling back to AT commands by
implementing a custom MMBroadbandModemQmiSimtech wouldn't be very bad.


-- 
Aleksander
https://aleksander.es
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20180816/c5a96458/attachment.html>