[review] SUPL server address validation

Aleksander Morgado aleksander at aleksander.es
Tue Aug 28 08:08:43 UTC 2018


Hey,

Most devices allow specifying the SUPL server in two different ways;
either as "IP and PORT" or "FQDN and PORT". Our API had support for
"IP and PORT" but then we would just fallback to a generic "URL"
string, which never wasn't really a valid URL.

This patch introduces some minor validation for these two cases, not
really fully validating that the FQDN string is a valid domain name,
but at least allowing to specify a port explicitly for that case.

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/34

Comments?

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list