[PATCH] API: don't depend on GLib in ModemManager headers

[Aleksander Morgado]

On Mon, Feb 5, 2018 at 5:37 PM, Dan Williams <dcbw at redhat.com> wrote:
> On Mon, 2018-02-05 at 09:53 +0100, Aleksander Morgado wrote:
>> We should only depend on GLib on the libmm-glib headers. Otherwise,
>> packages using just the core headers (e.g. ModemManagerQt) would also
>> need to build-depend on GLib and we don't want to enforce that.
>>
>>     cd ~/buildroot/output/build/kde-modemmanager-qt-v5.36.0/src &&
>> ~/buildroot/output/host/usr/bin/arm-cortexa9_neon-linux-gnueabihf-
>> g++  .... -fPIC -o
>> CMakeFiles/KF5ModemManagerQt_static.dir/bearer.cpp.o -c
>> ~/buildroot/output/build/kde-modemmanager-qt-v5.36.0/src/bearer.cpp
>>     In file included from ~/buildroot/output/host/usr/arm-buildroot-
>> linux-gnueabihf/sysroot/usr/include/ModemManager/ModemManager.h:41:0,
>>                      from ~/buildroot/output/build/kde-modemmanager-
>> qt-v5.36.0/src/generictypes.h:27,
>>                      from ~/buildroot/output/build/kde-modemmanager-
>> qt-v5.36.0/src/generictypes.cpp:23:
>>     ~/buildroot/output/host/usr/arm-buildroot-linux-
>> gnueabihf/sysroot/usr/include/ModemManager/ModemManager-
>> compat.h:23:18: fatal error: glib.h: No such file or directory
>>     compilation terminated.
>> ---
>>
>> Hey,
>>
>> This one is regarding the deprecated API items we include in the
>> ModemManager core headers.
>
> Seems fine to me.
>

Thanks for checking, in git master now.

-- 
Aleksander
https://aleksander.es