mm-modem-helpers-cinterion: update freq/band table

[matthew stanger]

git format-patch is attached. Sorry for the trouble.

On Fri, Jul 27, 2018 at 1:06 AM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> Hey
>
> On Thu, Jul 26, 2018 at 11:33 PM, matthew stanger <stangerm2 at gmail.com> wrote:
>> Greetings,
>>
>> Just a little refresher on the band table for Cinterion/Gelmato modems.
>>
>> Cheers,
>>
>
> Could you please resend it in a way I can just "git am" it?
> E.g. using git send-email or just attach it as a separate file after
> having retrieved it with "git format-patch".
>
> Thanks!
>
>>
>>
>> From f1469d884cc0737c2965d5897af399fe9048b3ad Mon Sep 17 00:00:00 2001
>> From: mstanger <matthew_stanger at trimble.com>
>> Date: Wed, 25 Jul 2018 14:44:27 -0600
>> Subject: [PATCH] mm-modem-helpers-cinterion: update freq/band table
>>
>> This info comes from PLS8-X/E/J/V/US, HC25 & PHS8 references, the
>> last two can be found publicly via Google search.
>>
>> Swapped bit-mask locations for G850 & PCS bands as they may have
>> changed with FW or where accidently put in the wrong place.
>>
>> Updated many 3G & 4G bit-mask fields.
>> ---
>>  plugins/cinterion/mm-modem-helpers-cinterion.c | 32 ++++++++++++++++++--------
>>  1 file changed, 22 insertions(+), 10 deletions(-)
>>
>> diff --git a/plugins/cinterion/mm-modem-helpers-cinterion.c
>> b/plugins/cinterion/mm-modem-helpers-cinterion.c
>> index 34b5cc84..c40ce998 100644
>> --- a/plugins/cinterion/mm-modem-helpers-cinterion.c
>> +++ b/plugins/cinterion/mm-modem-helpers-cinterion.c
>> @@ -36,21 +36,33 @@ typedef struct {
>>      MMModemBand mm_band;
>>  } CinterionBand;
>>
>> -/* Table checked in HC25 and PHS8 references. This table includes
>> both 2G and 3G
>> +/* Table checked in PLS8-X/E/J/V/US, HC25 & PHS8 references. The
>> table includes 2/3/4G
>>   * frequencies. Depending on which one is configured, one access technology or
>>   * the other will be used. This may conflict with the allowed mode
>> configuration
>>   * set, so you shouldn't for example set 3G frequency bands, and then use a
>>   * 2G-only allowed mode. */
>>  static const CinterionBand cinterion_bands[] = {
>> -    { (1 << 0), MM_MODEM_BAND_EGSM    },
>> -    { (1 << 1), MM_MODEM_BAND_DCS     },
>> -    { (1 << 2), MM_MODEM_BAND_PCS     },
>> -    { (1 << 3), MM_MODEM_BAND_G850    },
>> -    { (1 << 4), MM_MODEM_BAND_UTRAN_1 },
>> -    { (1 << 5), MM_MODEM_BAND_UTRAN_2 },
>> -    { (1 << 6), MM_MODEM_BAND_UTRAN_5 },
>> -    { (1 << 7), MM_MODEM_BAND_UTRAN_8 },
>> -    { (1 << 8), MM_MODEM_BAND_UTRAN_6 }
>> +    { (1 << 0), MM_MODEM_BAND_EGSM       },
>> +    { (1 << 1), MM_MODEM_BAND_DCS        },
>> +    { (1 << 2), MM_MODEM_BAND_G850       },
>> +    { (1 << 3), MM_MODEM_BAND_PCS        },
>> +    { (1 << 4), MM_MODEM_BAND_UTRAN_1    },
>> +    { (1 << 5), MM_MODEM_BAND_UTRAN_2    },
>> +    { (1 << 6), MM_MODEM_BAND_UTRAN_5    },
>> +    { (1 << 7), MM_MODEM_BAND_UTRAN_8    },
>> +    { (1 << 8), MM_MODEM_BAND_UTRAN_6    },
>> +    { (1 << 9), MM_MODEM_BAND_UTRAN_4    },
>> +    { (1 << 12), MM_MODEM_BAND_UTRAN_3   },
>> +    { (1 << 13), MM_MODEM_BAND_EUTRAN_1  },
>> +    { (1 << 14), MM_MODEM_BAND_EUTRAN_2  },
>> +    { (1 << 15), MM_MODEM_BAND_EUTRAN_3  },
>> +    { (1 << 16), MM_MODEM_BAND_EUTRAN_4  },
>> +    { (1 << 17), MM_MODEM_BAND_EUTRAN_5  },
>> +    { (1 << 18), MM_MODEM_BAND_EUTRAN_7  },
>> +    { (1 << 19), MM_MODEM_BAND_EUTRAN_8  },
>> +    { (1 << 20), MM_MODEM_BAND_EUTRAN_17 },
>> +    { (1 << 21), MM_MODEM_BAND_EUTRAN_20 },
>> +    { (1 << 22), MM_MODEM_BAND_EUTRAN_13 }
>>  };
>>
>>  /* Check valid combinations in 2G-only devices */
>> --
>> 2.16.2
>> _______________________________________________
>> ModemManager-devel mailing list
>> ModemManager-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
>
>
>
> --
> Aleksander
> https://aleksander.es
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cinterion-band-table-refresh.patch
Type: text/x-patch
Size: 2848 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20180727/ad29c490/attachment.bin>