g_assert_cmpmem and glib 2.46
Aleksander Morgado
aleksander at aleksander.es
Wed Nov 7 08:45:33 UTC 2018
Hey,
> The PCO patches I submitted earlier on used g_assert_cmpmem(), which I
> just realized that it is available in glib 2.46 or later.
> ModemManager requires glib 2.36 or later. Given that glib 2.45 was
> released about 3 years ago, I wonder if it's time to bump the minimum
> glib version. Otherwise, I can update the code not to use
> g_assert_cmpmem(). WDYT?
>
I keep thinking that we should maintain compatibility with Ubuntu
14.04, which isn't EOL yet. Ubuntu 14.04 has GLib 2.40. Maybe we
should keep the same deps until MM 1.10 is released and then just go
on and bump deps to newer versions. There are a bunch of GLib features
that I wouldn't mind to start using, truth be told...
For this specific patch, I think that we should skip using
g_assert_cmpmem() if possible, or otherwise just #ifdef it under a
GLIB_CHECK_VERSION() check.
--
Aleksander
https://aleksander.es
More information about the ModemManager-devel
mailing list