[PATCH 1/1] cli,call: fix incorrect string conversion of MMCallStateReason enum

Aleksander Morgado aleksander at aleksander.es
Fri Nov 30 10:35:48 UTC 2018


On 30/11/18 1:35, Ben Chan wrote:
> This patch fixes the following issue with string conversion of a MMCallStateReason enum:
> 
> mmcli-call.c:160:88: error: implicit conversion from enumeration type 'MMCallStateReason' to different enumeration type 'MMCallState' [-Werror,-Wenum-conversion]
>     mmcli_output_string (MMC_F_CALL_PROPERTIES_STATE_REASON, mm_call_state_get_string (mm_call_get_state_reason (call)));
>                                                              ~~~~~~~~~~~~~~~~~~~~~~~~  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---

Pushed to git master, thanks

>  cli/mmcli-call.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cli/mmcli-call.c b/cli/mmcli-call.c
> index d4930285..a871dbc0 100644
> --- a/cli/mmcli-call.c
> +++ b/cli/mmcli-call.c
> @@ -157,7 +157,7 @@ print_call_info (MMCall *call)
>      mmcli_output_string (MMC_F_CALL_PROPERTIES_NUMBER,       mm_call_get_number (call));
>      mmcli_output_string (MMC_F_CALL_PROPERTIES_DIRECTION,    mm_call_direction_get_string (mm_call_get_direction (call)));
>      mmcli_output_string (MMC_F_CALL_PROPERTIES_STATE,        mm_call_state_get_string (mm_call_get_state (call)));
> -    mmcli_output_string (MMC_F_CALL_PROPERTIES_STATE_REASON, mm_call_state_get_string (mm_call_get_state_reason (call)));
> +    mmcli_output_string (MMC_F_CALL_PROPERTIES_STATE_REASON, mm_call_state_reason_get_string (mm_call_get_state_reason (call)));
>      mmcli_output_string (MMC_F_CALL_PROPERTIES_AUDIO_PORT,   mm_call_get_audio_port (call));
>  
>      if (audio_format) {
> 


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list