[PATCH 1/2] modem-helpers: remove useless checks on always true condition

Ben Chan benchan at chromium.org
Sat Oct 27 06:00:05 UTC 2018


mm-modem-helpers.c:3075:31: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
     g_return_val_if_fail (idx >= 0, NULL);
                               ^
---
 src/mm-modem-helpers.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c
index 87e3754a..1da47a98 100644
--- a/src/mm-modem-helpers.c
+++ b/src/mm-modem-helpers.c
@@ -3072,7 +3072,6 @@ cind_response_new (const gchar *desc, guint idx, gint min, gint max)
     gchar *p;
 
     g_return_val_if_fail (desc != NULL, NULL);
-    g_return_val_if_fail (idx >= 0, NULL);
 
     r = g_malloc0 (sizeof (MM3gppCindResponse));
 
-- 
2.19.1.568.g152ad8e336-goog



More information about the ModemManager-devel mailing list