[PATCH] mm-modem-helpers-qmi: add missing LTE bands to nas_lte_bands_map

[Nick]

Hey Reinhard,

Thanks for the tip!  I made some additions, see the patch inline.  It now displays eutran-28 in the mmcli output but whenever I try to use —set-allowed-bands with any set of bands I get a page fault.

It seems like mm_modem_bands_to_qmi_band_preference() is the likely place to start digging, but that is just my hunch.

Debug output:
Sun Aug 18 10:30:29 2019 daemon.debug [12980]: <debug> [1566088229.221066] Setting new list of bands: 'eutran-1'
Sun Aug 18 10:30:29 2019 kern.info kernel: [ 2850.121024] do_page_fault(): sending SIGSEGV to ModemManager for invalid write access to 00000000
Sun Aug 18 10:30:29 2019 kern.info kernel: [ 2850.132164] epc = 77f49afc in libc.so[77ed8000+92000]
Sun Aug 18 10:30:29 2019 kern.info kernel: [ 2850.137562] ra  = 0048cdb5 in ModemManager[400000+da000]

Patch:
--- mm-modem-helpers-qmi.c.orig	2019-08-18 10:05:42.078434000 +1000
+++ qmi-helpers.c	2019-08-18 10:21:56.157171703 +1000
@@ -275,6 +275,13 @@
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_21, MM_MODEM_BAND_EUTRAN_21 },
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_24, MM_MODEM_BAND_EUTRAN_24 },
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_25, MM_MODEM_BAND_EUTRAN_25 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_26, MM_MODEM_BAND_EUTRAN_26 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_27, MM_MODEM_BAND_EUTRAN_27 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_28, MM_MODEM_BAND_EUTRAN_28 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_29, MM_MODEM_BAND_EUTRAN_29 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_30, MM_MODEM_BAND_EUTRAN_30 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_31, MM_MODEM_BAND_EUTRAN_31 },
+    { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_32, MM_MODEM_BAND_EUTRAN_32 },
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_33, MM_MODEM_BAND_EUTRAN_33 },
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_34, MM_MODEM_BAND_EUTRAN_34 },
     { QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_35, MM_MODEM_BAND_EUTRAN_35 },
@@ -472,6 +479,13 @@
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_21, MM_MODEM_BAND_EUTRAN_21 },
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_24, MM_MODEM_BAND_EUTRAN_24 },
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_25, MM_MODEM_BAND_EUTRAN_25 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_26, MM_MODEM_BAND_EUTRAN_26 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_27, MM_MODEM_BAND_EUTRAN_27 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_28, MM_MODEM_BAND_EUTRAN_28 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_29, MM_MODEM_BAND_EUTRAN_29 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_30, MM_MODEM_BAND_EUTRAN_30 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_31, MM_MODEM_BAND_EUTRAN_31 },
+    { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_32, MM_MODEM_BAND_EUTRAN_32 },
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_33, MM_MODEM_BAND_EUTRAN_33 },
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_34, MM_MODEM_BAND_EUTRAN_34 },
     { QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_35, MM_MODEM_BAND_EUTRAN_35 },
@@ -696,6 +710,13 @@
     { QMI_NAS_ACTIVE_BAND_EUTRAN_21, MM_MODEM_BAND_EUTRAN_21 },
     { QMI_NAS_ACTIVE_BAND_EUTRAN_24, MM_MODEM_BAND_EUTRAN_24 },
     { QMI_NAS_ACTIVE_BAND_EUTRAN_25, MM_MODEM_BAND_EUTRAN_25 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_26, MM_MODEM_BAND_EUTRAN_26 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_27, MM_MODEM_BAND_EUTRAN_27 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_28, MM_MODEM_BAND_EUTRAN_28 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_29, MM_MODEM_BAND_EUTRAN_29 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_30, MM_MODEM_BAND_EUTRAN_30 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_31, MM_MODEM_BAND_EUTRAN_31 },
+    { QMI_NAS_ACTIVE_BAND_EUTRAN_32, MM_MODEM_BAND_EUTRAN_32 },
     { QMI_NAS_ACTIVE_BAND_EUTRAN_33, MM_MODEM_BAND_EUTRAN_33 },
     { QMI_NAS_ACTIVE_BAND_EUTRAN_34, MM_MODEM_BAND_EUTRAN_34 },
     { QMI_NAS_ACTIVE_BAND_EUTRAN_35, MM_MODEM_BAND_EUTRAN_35 },