[review] Fix sending/storing SMS messages when other AT commands get in the way

Dan Williams dcbw at redhat.com
Mon Jun 3 14:38:20 UTC 2019

On Sun, 2019-05-19 at 09:42 +0200, Aleksander Morgado wrote:
> Hey Dan & all,
> The original fix I had for this issue was to always add raw commands
> to the head of the queue inside the serial port:
> https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/103
> The new fix I have for this issue is to setup a new queue of
> operations at modem object level, so that no AT command/sequence can
> be run if another AT command/sequence is running, and then I ported
> the SMS send/store operations to be run as a sequence instead of
> independent commands:
> https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/105
> I'm not sure, but looking at both MRs as if I hadn't written them
> myself, I think that the original fix in MR#103 is much simpler, the
> second one introduces another level of complexity that not sure if
> it's needed.
> What do you think?

I reviewed and merged #103.


More information about the ModemManager-devel mailing list