ModemManager Crash (1.18.2) when ip-type is ipv4v6 (MBIM)

[Amol Lad]

Hi,

I'm finding that ModemManager crashes when ip-type is ipv4v6 in -simple-connect in MBIM mode. After investigation, I found that below seems to fix the crash

diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c
index d509929..bf66c5d 100644
--- a/src/mm-bearer-mbim.c
+++ b/src/mm-bearer-mbim.c
@@ -406,7 +406,7 @@ ip_configuration_query_ready (MbimDevice   *device,
                     str = g_inet_address_to_string (addr);
                     mm_obj_dbg (self, "    DNS [%u]: '%s'", i, str);
                 }
-                g_object_unref (addr);
+                //g_object_unref (addr);
             }
         }

--

The original code is:

mm-bearer-mbin.c: ip_configuration_query_ready()

        if ((ipv6configurationavailable & MBIM_IP_CONFIGURATION_AVAILABLE_FLAG_DNS) && ipv6dnsservercount) {
            guint i;

            mm_obj_dbg (self, "  DNS addresses (%u)", ipv6dnsservercount);
            for (i = 0; i < ipv6dnsservercount; i++) {
                g_autoptr(GInetAddress)  addr = NULL;

                addr = g_inet_address_new_from_bytes ((guint8 *)&ipv6dnsserver[i], G_SOCKET_FAMILY_IPV6);
                if (!g_inet_address_get_is_any (addr)) {
                    g_autofree gchar *str = NULL;

                    str = g_inet_address_to_string (addr);
                    mm_obj_dbg (self, "    DNS [%u]: '%s'", i, str);
                }
                g_object_unref (addr);  <-- This seems to cause crash
            }
        }

Thanks