No PPP / limit plugins first draft patch

[Peter Naulls]

On 1/17/22 12:21 PM, Peter Naulls wrote:
> 
> This removes PPP entirely from consideration in ModemManager. This has 2 patches 
> - one for the OpenWrt build (against the 21.02 release(ish)) and MM itself 
> (against 1.18.4).
> 
> This is definitely incomplete. In particular, the MM scripts still reference 
> pppd.  And ppp (pppoe in particular) is somewhat sewn into luci.  My goal
> here would be to completely remove ppp(d) from the OpenWrt build if possible.
> 
> Also, I think some of the plugins rely on PPP, turning it off for some will
> definitely break.  However, this suffices for my immediate needs. Obviously
> the plugin selection needs to be expanded in Config.in.

I turned off all the OpenWrt PPP options including the luci plugins, and am
now running completely without PPP.  I went through luci and didn't see
any problems.

This is the final change I made (locally only of course):


--- a/modemmanager.sh
+++ b/modemmanager.sh
@@ -2,12 +2,12 @@
  # Copyright (C) 2016-2019 Aleksander Morgado <aleksander at aleksander.es>

  [ -x /usr/bin/mmcli ] || exit 0
-[ -x /usr/sbin/pppd ] || exit 0
+#[ -x /usr/sbin/pppd ] || exit 0

  [ -n "$INCLUDE_ONLY" ] || {
  	. /lib/functions.sh
  	. ../netifd-proto.sh
-	. ./ppp.sh
+	#. ./ppp.sh
  	init_proto "$@"
  }

For a more correct setup, this could be done during the install processing with
'sed' or maybe split the PPP scripts to be optionally included (in the package
and then in the scripts) when enabled.