Build error with ModemManager 1.18.6 / meson 0.53.2

[Sven Schwermer]

Hi Aleksander and Iñigo,

I can confirm that the patches

2bc697ce32877e2074ea19a8639e256ecfb3233a
81c3b59f75ccc09d87100196ca2932de371320de

fix the issue. Thanks for the quick help!

Best regards,
Sven

On 2/28/22 21:27, Aleksander Morgado wrote:
> Hey,
> 
> Adding Iñigo in CC
> 
>>
>> I'm getting a build error for ModemManager 1.18.6 with meson 0.53.2.
>> This error does not occur with meson 0.61.2 in an otherwise identical
>> environment. According to the NEWS file, the minimum meson version
>> should be 0.53.0 (ModemManager 1.18.2).
>>
>> [...]
> 
> Iñigo, any idea about this issue? Not sure I've seen it myself
> 
>>
>> [127/452] cc -Iplugins/92cd10e@@mm-shared-icera at sha -Iplugins
>> -I../plugins -I. -I../ -Isrc -I../src -I../src/kerneldevice -Ilibmm-glib
>> -I../libmm-glib -Iinclude -I../include -Ilibmm-glib/generated
>> -I../libmm-glib/generated -I/usr/include/glib-2.0
>> -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4
>> -I/usr/include/libmount -I/usr/include/blkid -fdiagnostics-color=always
>> -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu89 -O2
>> -g -DHAVE_CONFIG_H -Wno-unused-parameter -Wno-cast-function-type
>> -Wno-packed -Wno-float-equal -Wno-missing-field-initializers
>> -fno-strict-aliasing -Waggregate-return -Wcast-align
>> -Wdeclaration-after-statement -Wdouble-promotion -Wduplicated-branches
>> -Wduplicated-cond -Wformat=2 -Wformat-nonliteral -Wformat-security
>> -Winit-self -Winline -Wjump-misses-init -Wlogical-op -Wnested-externs
>> -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs
>> -Wmissing-noreturn -Wmissing-prototypes -Wnull-dereference
>> -Wpointer-arith -Wredundant-decls -Wrestrict -Wreturn-type -Wshadow
>> -Wstrict-prototypes -Wsuggest-attribute=format -Wswitch-default
>> -Wswitch-enum -Wundef -Wunused-but-set-variable -Wwrite-strings -fPIC
>> -pthread -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56
>> -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56
>> -DGLIB_DISABLE_DEPRECATION_WARNINGS '-DMM_MODULE_NAME="shared-icera"'
>> -MD -MQ
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o'
>> -MF
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o.d'
>> -o
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o'
>> -c ../plugins/icera/mm-broadband-bearer-icera.c
>> FAILED:
>> plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o
>> cc -Iplugins/92cd10e@@mm-shared-icera at sha -Iplugins -I../plugins -I.
>> -I../ -Isrc -I../src -I../src/kerneldevice -Ilibmm-glib -I../libmm-glib
>> -Iinclude -I../include -Ilibmm-glib/generated -I../libmm-glib/generated
>> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>> -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid
>> -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall
>> -Winvalid-pch -Wextra -std=gnu89 -O2 -g -DHAVE_CONFIG_H
>> -Wno-unused-parameter -Wno-cast-function-type -Wno-packed
>> -Wno-float-equal -Wno-missing-field-initializers -fno-strict-aliasing
>> -Waggregate-return -Wcast-align -Wdeclaration-after-statement
>> -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond -Wformat=2
>> -Wformat-nonliteral -Wformat-security -Winit-self -Winline
>> -Wjump-misses-init -Wlogical-op -Wnested-externs -Wmissing-declarations
>> -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn
>> -Wmissing-prototypes -Wnull-dereference -Wpointer-arith
>> -Wredundant-decls -Wrestrict -Wreturn-type -Wshadow -Wstrict-prototypes
>> -Wsuggest-attribute=format -Wswitch-default -Wswitch-enum -Wundef
>> -Wunused-but-set-variable -Wwrite-strings -fPIC -pthread
>> -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56
>> -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56
>> -DGLIB_DISABLE_DEPRECATION_WARNINGS '-DMM_MODULE_NAME="shared-icera"'
>> -MD -MQ
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o'
>> -MF
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o.d'
>> -o
>> 'plugins/92cd10e@@mm-shared-icera at sha/icera_mm-broadband-bearer-icera.c.o'
>> -c ../plugins/icera/mm-broadband-bearer-icera.c
>> ../plugins/icera/mm-broadband-bearer-icera.c:35:10: fatal error:
>> mm-daemon-enums-types.h: No such file or directory
>>      35 | #include "mm-daemon-enums-types.h"
>>         |          ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> 
> --
> Aleksander
> https://aleksander.es