patch - Remove PPP round 2

Peter Naulls peter at chocky.org
Wed Feb 1 17:03:03 UTC 2023



I revised my earlier removal of PPP from the ModemManager build to be more 
complete. I'd like to remove it from the enums, but these are generated by meson
and it'll still pick up #ifdefed out items - I couldn't find a mechanism to make 
this work.

Also a patch against the Makefile in OpenWrt to use this and update from 1.20.2
to 1.20.4. Also note the previous patch I posted with the handling of .conf 
files vs no MBIM.

To be clear on this, even on largely well behaved modems, timeouts can still 
occur, or a reset can happen at the "wrong" time, or other race conditions, 
causing a trigger into PPP mode when it is not required. For my use, attempting
to use PPP is never the answer - we need to fall back to an error condition, or
retry etc - cycling on trying to use PPP results in grief, from painful and 
extensive experience of this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 802-no-ppp.diff
Type: text/x-patch
Size: 11485 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20230201/e7edd553/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makefile.patch
Type: text/x-patch
Size: 1271 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20230201/e7edd553/attachment-0001.bin>


More information about the ModemManager-devel mailing list