Alexsander, I'm traveling right now will test as soon as I get back tomorrow. <div class="gmail_extra"> <div class="gmail_quote">On Nov 24, 2016 2:58 AM, "Aleksander Morgado" <<a href="mailto:aleksander@aleksander.es">aleksander@aleksander.es</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Matthew, On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado <<a href="mailto:aleksander@aleksander.es">aleksander@aleksander.es</a>> wrote: > Great work! it looks really good now, although there are some small > things that could still be fixed. Let me prepare a branch with your > patch and I'll include some additional patches for you to review. Please check the 'stanger/cinterion' branch in the upstream git repository: <a href="https://cgit.freedesktop.org/ModemManager/ModemManager/log/?h=stanger/cinterion" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/ModemManager/ModemManager/log/?h=stanger/cinterion</a> I've included several changes that I suggested in previous reviews, like avoiding the enabling phase for the SWWAN feature support check, or the simpler ^SWWAN response parser. Let me know what you think, and please test the branch with a real device and let me know if you find any issue. BTW; I'm worried that we're binding the logic too much to a specific device with 2 interfaces; I've seen some online AT command reference that doesn't even talk about the third parameter to specify interface index in AT^SWWAN= set operations: <a href="http://www.seapraha.cz/download/pls8-e_atc_v01000_tcm216-155309.pdf" rel="noreferrer" target="_blank">http://www.seapraha.cz/download/pls8-e_atc_v01000_tcm216-155309.pdf</a> But for now I guess we're good. -- Aleksander <a href="https://aleksander.es" rel="noreferrer" target="_blank">https://aleksander.es</a> </blockquote></div></div>