<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">sure I can test it today or the next week</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">BR,<br>Carlo</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 24 March 2017 at 14:51, Aleksander Morgado <span dir="ltr"><<a href="mailto:aleksander@aleksander.es" target="_blank">aleksander@aleksander.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The vendor id/string based rules should already be enough to get the<br>
telit plugin bind telit devices.<br>
<br>
This simplifies support for future Telit devices, as we wouldn't need<br>
any additional change in the plugin. It also helps when working with<br>
RS232 devices as the user wouldn't need to add the explicit tag to get<br>
the devices bound to this plugin.<br>
<br>
<a href="https://bugs.freedesktop.org/show_bug.cgi?id=100373" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=100373</a><br>
---<br>
<br>
Hey Carlo & Daniele,<br>
<br>
This patch removes the need of having an explicit ID_MM_TELIT_TAGGED to flag those devices that may be grabbed by the Telit plugin.<br>
<br>
Could you test it with your devices to see if it works as expected?<br>
<br>
---<br>
 plugins/dell/77-mm-dell-port-<wbr>types.rules   | 3 +--<br>
 plugins/telit/77-mm-telit-<wbr>port-types.rules | 9 ---------<br>
 plugins/telit/mm-plugin-telit.<wbr>c            | 6 ------<br>
 3 files changed, 1 insertion(+), 17 deletions(-)<br>
<br>
diff --git a/plugins/dell/77-mm-dell-<wbr>port-types.rules b/plugins/dell/77-mm-dell-<wbr>port-types.rules<br>
index d619456c..bbb59b92 100644<br>
--- a/plugins/dell/77-mm-dell-<wbr>port-types.rules<br>
+++ b/plugins/dell/77-mm-dell-<wbr>port-types.rules<br>
@@ -9,8 +9,7 @@ LABEL="mm_dell_vendorcheck"<br>
 SUBSYSTEMS=="usb", ATTRS{bInterfaceNumber}=="?*", ENV{.MM_USBIFNUM}="$attr{<wbr>bInterfaceNumber}"<br>
<br>
 # DW5580 is a Dell-branded Telit modem<br>
-# tag is needed here both for dynamic port recognition and minimizing port probing time<br>
-ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81ba", ENV{ID_MM_TELIT_TAGGED}="1"<br>
+# tag is needed here for dynamic port recognition<br>
 ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81ba", ENV{ID_MM_TELIT_PORTS_TAGGED}=<wbr>"1"<br>
<br>
 GOTO="mm_dell_port_types_end"<br>
diff --git a/plugins/telit/77-mm-telit-<wbr>port-types.rules b/plugins/telit/77-mm-telit-<wbr>port-types.rules<br>
index 1b58a3d9..01538cb6 100644<br>
--- a/plugins/telit/77-mm-telit-<wbr>port-types.rules<br>
+++ b/plugins/telit/77-mm-telit-<wbr>port-types.rules<br>
@@ -10,45 +10,36 @@ SUBSYSTEMS=="usb", ATTRS{bInterfaceNumber}=="?*", ENV{.MM_USBIFNUM}="$attr{bInte<br>
 # UC864-E, UC864-E-AUTO, UC864-K, UC864-WD, UC864-WDU<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1003", ENV{.MM_USBIFNUM}=="00", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1003", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_TELIT_PORT_TYPE_AUX}<wbr>="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1003", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # UC864-G<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1004", ENV{.MM_USBIFNUM}=="00", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1004", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>NMEA}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1004", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_TELIT_PORT_TYPE_AUX}<wbr>="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1004", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # CC864-DUAL<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1005", ENV{.MM_USBIFNUM}=="00", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1005", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>NMEA}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1005", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_TELIT_PORT_TYPE_AUX}<wbr>="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1005", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # CC864-SINGLE, CC864-KPS<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1006", ENV{.MM_USBIFNUM}=="00", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1006", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_TELIT_PORT_TYPE_AUX}<wbr>="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1006", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # DE910-DUAL<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1010", ENV{.MM_USBIFNUM}=="01", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>NMEA}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1010", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_TELIT_PORT_TYPE_AUX}<wbr>="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1010", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1010", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # CE910-DUAL<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1011", ENV{.MM_USBIFNUM}=="01", ENV{ID_MM_TELIT_PORT_TYPE_<wbr>MODEM}="1"<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="1011", ENV{ID_MM_TELIT_TAGGED}="1"<br>
<br>
 # HE910, UE910, UL865 (dynamic port identification supported)<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0021", ENV{ID_MM_TELIT_TAGGED}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0021", ENV{ID_MM_TELIT_PORTS_TAGGED}=<wbr>"1"<br>
<br>
 # GE910 (dynamic port identification supported)<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0022", ENV{ID_MM_TELIT_TAGGED}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0022", ENV{ID_MM_TELIT_PORTS_TAGGED}=<wbr>"1"<br>
<br>
 # LE910 V2<br>
-ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0036", ENV{ID_MM_TELIT_TAGGED}="1"<br>
 ATTRS{idVendor}=="1bc7", ATTRS{idProduct}=="0036", ENV{ID_MM_TELIT_PORTS_TAGGED}=<wbr>"1"<br>
<br>
 LABEL="mm_telit_port_types_<wbr>end"<br>
diff --git a/plugins/telit/mm-plugin-<wbr>telit.c b/plugins/telit/mm-plugin-<wbr>telit.c<br>
index abb87e4f..57ecd444 100644<br>
--- a/plugins/telit/mm-plugin-<wbr>telit.c<br>
+++ b/plugins/telit/mm-plugin-<wbr>telit.c<br>
@@ -91,11 +91,6 @@ mm_plugin_create (void)<br>
     /* Vendors: Telit */<br>
     static const guint16 vendor_ids[] = { 0x1bc7, 0 };<br>
     static const gchar *vendor_strings[] = { "telit", NULL };<br>
-    /* Only handle TELIT tagged devices here. */<br>
-    static const gchar *udev_tags[] = {<br>
-        "ID_MM_TELIT_TAGGED",<br>
-        NULL<br>
-    };<br>
     /* Custom init for port identification */<br>
     static const MMAsyncMethod custom_init = {<br>
         .async  = G_CALLBACK (telit_custom_init),<br>
@@ -109,7 +104,6 @@ mm_plugin_create (void)<br>
                       MM_PLUGIN_ALLOWED_VENDOR_IDS,     vendor_ids,<br>
                       MM_PLUGIN_ALLOWED_VENDOR_<wbr>STRINGS, vendor_strings,<br>
                       MM_PLUGIN_ALLOWED_AT,             TRUE,<br>
-                      MM_PLUGIN_ALLOWED_UDEV_TAGS,      udev_tags,<br>
                       MM_PLUGIN_CUSTOM_INIT,            &custom_init,<br>
                       NULL));<br>
 }<br>
--<br>
2.12.0<br>
</blockquote></div><br></div>