<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">Hey,</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><font color="#737373" style="font-family:"Ubuntu Mono";font-size:17.3333px">> Carlo, any chance you can make a quick test with these patches to see</font><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><font color="#737373" style="font-family:"Ubuntu Mono";font-size:17.3333px">> if they work as expected in the Telit modems? One of the changes I</font><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><font color="#737373" style="font-family:"Ubuntu Mono";font-size:17.3333px">> see is that the Telit plugin previously did the AT+CMER command only</font><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><font color="#737373" style="font-family:"Ubuntu Mono";font-size:17.3333px">> in the secondary port, while now we do it in both primary and</font><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><font color="#737373" style="font-family:"Ubuntu Mono";font-size:17.3333px">> secondary, not sure if that's an issue?</font><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">I guess the reason is that if the primary port is used for data</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">(i.e. PPPD) notification won't arrive or will be buffered, according</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">to the parameters passed to +CMER.</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">If we send +CMER in both ports, are we gonna receive URCs twice?</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">However, I'm not aware of any different behavior of Telit plugins</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">respect this case, so if it's fine for the other plugins, I think</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">it's ok for Telit one too.</span><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><br style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px"><span style="color:rgb(92,97,108);font-family:"Ubuntu Mono";font-size:17.3333px">I'll try the patch and keep you updated</span><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 21 May 2017 at 14:54, Aleksander Morgado <span dir="ltr"><<a href="mailto:aleksander@aleksander.es" target="_blank">aleksander@aleksander.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Dan, Carlo & everyone,<br>
<br>
This patch series implements the checking of the AT+CMER command parameters so that we can enable or disable them without error. The parser only checks the 'mode' (1st field) and 'ind' (4th field) settings, as those are the ones we request to update.<br>
<br>
Also modified the Cinterion and Telit plugins to avoid requiring custom AT+CMER settings (they had one because some devices didn't support ind=1, only ind=2). I've also seen the case where AT+CMER cannot even be disabled (mode=1 the only one allowed, as in the EM7345), and in that case we just skip the command.<br>
<br>
Carlo, any chance you can make a quick test with these patches to see if they work as expected in the Telit modems? One of the changes I see is that the Telit plugin previously did the AT+CMER command only in the secondary port, while now we do it in both primary and secondary, not sure if that's an issue?<br>
<br>
Cheers!<br>
<br>
[PATCH 1/4] helpers: new 'AT+CMER=?' parser<br>
[PATCH 2/4] broadband-modem: query +CMER format before enabling/disabling<br>
[PATCH 3/4] cinterion: remove custom +CMER enabling<br>
[PATCH 4/4] telit: remove custom +CMER enabling<br>
</blockquote></div><br></div>