<div dir="ltr">lgtm<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 22, 2017 at 1:59 AM, Aleksander Morgado <span dir="ltr"><<a href="mailto:aleksander@aleksander.es" target="_blank">aleksander@aleksander.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Ben, Dan and everyone,<br>
<br>
These patches try to consolidate how the WITH_XXXX per-feature symbols are defined in the project: the symbols would only be defined when the feature is enabled.<br>
<br>
Ben, PATCH 2/4 would be equivalent to the fix you posted.<br>
<br>
What do you think?<br>
<br>
[PATCH 1/4] build: only define WITH_POLKIT if enabled<br>
[PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled<br>
[PATCH 3/4] build: WITH_UDEV is only defined when enabled<br>
[PATCH 4/4] build: rename --with-suspend-resume to --with-systemd-suspend-resume<br>
</blockquote></div><br></div></div>