Yes, I agree. That's why it's on a different patch <div class="gmail_quote"><div dir="ltr">On Tue, 1 Aug 2017, 13:12 Aleksander Morgado, <<a href="mailto:aleksander@aleksander.es">aleksander@aleksander.es</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Aug 1, 2017 at 12:31 PM, Carlo Lobrano <<a href="mailto:c.lobrano@gmail.com" target="_blank">c.lobrano@gmail.com</a>> wrote: >> Aren't the sim hot swap unsolicited messages received always, regardless >> of whether the modem is enabled or disabled? > > disabling_stopped function releases both ports contexts, so we don't receive > unsolicited on SIM swap ports. > Wait, I don't think that's ok. The SIM swap ports context is allocated during initialization, and should exist until the object is destroyed. We shouldn't be removing this context when the disable() happens, otherwise we wouldn't get SIM hot swap events when the modem is disabled. -- Aleksander <a href="https://aleksander.es" rel="noreferrer" target="_blank">https://aleksander.es</a> </blockquote></div>