<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">> Pushed to git master after fixing up the change in the file mode line, > which I assume wasn't on purpose :)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Indeed, I don't even know how I made it :D</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks </div></div><div class="gmail_extra"> <div class="gmail_quote">On 29 August 2017 at 11:20, Aleksander Morgado <<a href="mailto:aleksander@aleksander.es" target="_blank">aleksander@aleksander.es</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Aug 29, 2017 at 9:15 AM, Carlo Lobrano <<a href="mailto:c.lobrano@gmail.com">c.lobrano@gmail.com</a>> wrote: > Currently when the modem is disabled, it releases SIM hot swap ports context, > and is not able to receive any notification about the SIM status. > > This patch keeps these ports opened when Modem is disabled and released them > only when SIM swap is detected or when modem is released. > --- > > If I understood correctly, the only change was to be done in broadband modem's finalize. > I also looked at enabled_ports_ctx as reference and it seems there are not other places to > relese the port contexts. > Pushed to git master after fixing up the change in the file mode line, which I assume wasn't on purpose :) Thanks! <div><div class="h5"> > --- > > src/mm-broadband-modem.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c > index 552bdc5..b298721 100644 > --- a/src/mm-broadband-modem.c > +++ b/src/mm-broadband-modem.c > @@ -1,5 +1,4 @@ > -/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ > -/* > +/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- *//* > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2 of the License, or > @@ -8640,10 +8639,6 @@ disabling_stopped (MMBroadbandModem *self, > self->priv->enabled_ports_ctx = NULL; > } > > - if (self->priv->sim_hot_swap_ports_ctx) { > - ports_context_unref (self->priv->sim_hot_swap_ports_ctx); > - self->priv->sim_hot_swap_ports_ctx = NULL; > - } > return TRUE; > } > > @@ -10661,6 +10656,9 @@ finalize (GObject *object) > if (self->priv->enabled_ports_ctx) > ports_context_unref (self->priv->enabled_ports_ctx); > > + if (self->priv->sim_hot_swap_ports_ctx) > + ports_context_unref (self->priv->sim_hot_swap_ports_ctx); > + > if (self->priv->modem_3gpp_registration_regex) > mm_3gpp_creg_regex_destroy (self->priv->modem_3gpp_registration_regex); > > -- > 2.9.3 > </div></div>> _______________________________________________ > ModemManager-devel mailing list > <a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel</a> -- Aleksander <a href="https://aleksander.es" rel="noreferrer" target="_blank">https://aleksander.es</a> </blockquote></div> </div>