<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 21, 2017 at 2:15 PM, Piotr Figiel <span dir="ltr"><<a href="mailto:figiel@gmail.com" target="_blank">figiel@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
 I dug into the issue a little bit deeper and I think I found the<br>
source of the problem.<br>
 The connection state machine seem to enter a dead end in<br>
mm-bearer-qmi.c on CONNECT_STEP_ENABLE_<wbr>INDICATIONS_IPV4 case for<br>
libqmi < 1.18.0.<br>
 With this patch it works, you can include it if you find it OK, this<br>
is on top of mm-1-6.<br>
<br>
Best regards, Piotr.<br>
<br>
>From d5ffba8afb2c18e51eb0a982b31a0c<wbr>92b7337e64 Mon Sep 17 00:00:00 2001<br>
From: Piotr Figiel <<a href="mailto:p.figiel@camlintechnologies.com">p.figiel@camlintechnologies.<wbr>com</a>><br>
Date: Thu, 21 Dec 2017 14:08:35 +0100<br>
Subject: [PATCH] bearer-qmi: fix connect with libqmi lower than 1.18<br>
<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:monospace,monospace">​Ouch, good one! Pushed an updated patch to mm-1-6 that also considers the same thing in the IPv6 case a bit later.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">And found a related issue while looking at the code, going to fix that one as well.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
 src/mm-bearer-qmi.c | 4 +++-<br>
 1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mm-bearer-qmi.c b/src/mm-bearer-qmi.c<br>
index c75d5e4..c92e971 100644<br>
--- a/src/mm-bearer-qmi.c<br>
+++ b/src/mm-bearer-qmi.c<br>
@@ -1156,8 +1156,10 @@ connect_context_step (ConnectContext *ctx)<br>
                                                ctx->cancellable,<br>
                                                (GAsyncReadyCallback)<br>
connect_enable_indications_<wbr>ipv4_ready,<br>
                                                ctx);<br>
-#endif<br>
         return;<br>
+#else<br>
+        ctx->step++;<br>
+#endif<br>
<br>
     case CONNECT_STEP_START_NETWORK_<wbr>IPV4: {<br>
         QmiMessageWdsStartNetworkInput *input;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
</font></span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
ModemManager-devel mailing list<br>
<a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.<wbr>freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/modemmanager-<wbr>devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Aleksander<br><a href="https://aleksander.es" target="_blank">https://aleksander.es</a></div>
</div></div>