<div dir="ltr"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 27, 2018 at 6:31 AM Aleksander Morgado <<a href="mailto:aleksander@aleksander.es">aleksander@aleksander.es</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey Ben,<br>
<br>
><br>
> See <a href="https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/27" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/27</a><br>
><br>
> This MR adds a 'Pco' property to the Modem3gpp interface for reporting<br>
> raw PCO values received from the network as we discussed in<br>
> <a href="https://lists.freedesktop.org/archives/modemmanager-devel/2018-July/006514.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/archives/modemmanager-devel/2018-July/006514.html</a>.<br>
> The current implementation supports MBIM modems that implement the<br>
> MBIM_CID_PCO notification.  A subsequent MR will migrate the<br>
> altair-lte plugin to make use of the 'Pco' property, which will then<br>
> allow us to deprecate the SubscriptionState property in Modem3gpp<br>
> interface.<br>
><br>
<br>
These warnings happen now when building master, could you take a look<br>
at them? They look just like some missing G-I annotation tags<br>
<br>
  GISCAN   ModemManager-1.0.gir<br>
mm-modem-3gpp.c:311: Warning: ModemManager: mm_modem_3gpp_get_pco:<br>
return value: Missing (element-type) annotation<br>
mm-pco.h:64: Warning: ModemManager: mm_pco_list_free: argument<br>
pco_list: Missing (element-type) annotation<br>
mm-pco.h:65: Warning: ModemManager: mm_pco_list_add: argument<br>
pco_list: Missing (element-type) annotation<br>
mm-pco.h:65: Warning: ModemManager: mm_pco_list_add: return value:<br>
Missing (element-type) annotation<br>
mm-pco.h:76: Warning: ModemManager: mm_pco_from_variant: return value:<br>
Missing (transfer) annotation<br>
  GICOMP   ModemManager-1.0.gir<br></blockquote><div><br></div><div>Aleksander, could you try this patch and see if it fixes the issue? Thanks.</div><div><br></div><div><a href="https://lists.freedesktop.org/archives/modemmanager-devel/2018-August/006624.html">https://lists.freedesktop.org/archives/modemmanager-devel/2018-August/006624.html</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
Aleksander<br>
<a href="https://aleksander.es" rel="noreferrer" target="_blank">https://aleksander.es</a><br>
</blockquote></div></div></div>