<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Thanks Aleksander<br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <div id="Signature"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;"> <p></p> <div> <table style="color:rgb(35,0,102); font-family:Verdana,Arial; font-size:12px; line-height:18px; table-layout:fixed"> <tbody> <tr> <td colspan="2" style="padding-bottom:12px; width:356px"><b style="font-size:14px">Sebastien Fabre</b><br> Embedded Software Engineer </td> </tr> <tr> <td valign="top"><a href="http://www.sigfox.com" target="_blank" style="text-decoration:none; outline:none" id="LPNoLP"><img style="border:0px; margin:4px 10px 0px 0px" width="94" height="30" src="http://www.sigfox.com/static/media/signature_sigfox_logo_nov16.png"></a> </td> <td style="padding-left:10px" valign="top">Bâtiment E-volution - 425, rue Jean Rostand <br> 31670 Labège, France <br> <a href="mailto:sebastien.fabre@sigfox.com" style="color:#230066" id="LPNoLP">sebastien.fabre@sigfox.com</a><br> <a href="http://www.sigfox.com" target="_blank" style="color:#8024FF; text-decoration:none" id="LPNoLP"><b>sigfox.com</b></a> <div style="margin-top:8px"><a href="https://twitter.com/sigfox" target="_blank" style="text-decoration:none; outline:none" id="LPNoLP"><img title="twitter" style="border:none" width="32" height="32" src="http://www.sigfox.com/static/media/T.png"> </a><a href="http://www.facebook.com/sigfox" target="_blank" style="text-decoration:none; outline:none; margin-left:5px" id="LPNoLP"><img title="facebook" style="border:none" width="32" height="32" src="http://www.sigfox.com/static/media/F.png"> </a><a href="http://www.linkedin.com/company/2731408" target="_blank" style="text-decoration:none; outline:none; margin-left:5px" id="LPNoLP"><img title="linkedin" style="border:none; margin-top:1px" width="32" height="32" src="http://www.sigfox.com/static/media/L.png"> </a><a href="https://www.youtube.com/sigfox" target="_blank" style="text-decoration:none; outline:none; margin-left:5px" id="LPNoLP" title="Ctrl+Cliquer ou appuyer pour suivre le lien"><img title="youtube" style="border:none" width="32" height="32" src="http://www.sigfox.com/static/media/Y.png"> </a></div> </td> </tr> </tbody> </table> </div> <br> <p></p> </div> </div> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>De :</b> Aleksander Morgado <aleksander@aleksander.es><br> <b>Envoyé :</b> mercredi 28 novembre 2018 12:03:37<br> <b>À :</b> Sebastien Fabre<br> <b>Cc :</b> ModemManager (development)<br> <b>Objet :</b> Re: Crashes in g_hash_table_iter_next call</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hey,<br> <br> ><br> > > Have you not found the issue with MM 1.8? Or just not tried?<br> ><br> ><br> > We have not tried with MM 1.8 (we have not a method to reproduce these crashes).<br> ><br> > Do you think that "self->priv->ports" value should be checked before using it in all methods of mm-base-modem.c ? Or just destroyed and set to NULL in finalize ?<br> ><br> <br> If we take this as a race condition, probably just modifying<br> mm_base_modem_find_ports() is enough. What I was referring to was that<br> it is probably easier to reproduce this problem if there are dangling<br> modem references around (I believe I've fixed a couple of these in<br> 1.8.x). But in theory without the dangling references it may still<br> happen if very unlucky.<br> <br> I've pushed a fix to git master to handle this:<br> <a href="https://gitlab.freedesktop.org/mobile-broadband/ModemManager/commit/7510b3355d7c1a670ab1eff373ef04bc5a8ad282">https://gitlab.freedesktop.org/mobile-broadband/ModemManager/commit/7510b3355d7c1a670ab1eff373ef04bc5a8ad282</a><br> <br> -- <br> Aleksander<br> <a href="https://aleksander.es">https://aleksander.es</a><br> </div> </span></font></div> </body> </html>