<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hey everyone!<div class=""><br class=""></div><div class="">The final missing piece before a merge might be making sure the scripts pass Shellcheck, which, if you don’t know, ensures the script is POSIX compliant. I have started on that work in my Shellcheck branch linked below. If anyone would like to test, I think the modemmanager.common file is done, but modemmanager.proto might be ready tomorrow. I could only test it on OpenWrt, which uses the Almquist shell. Tested by stopping/starting MM, rebooting, debug mode, and reading the logread output.</div><div class=""><br class=""></div><div class="">Code</div><div class=""><a href="https://github.com/nickberry17/packages-1/tree/shellcheck/net/modemmanager/files" class="">https://github.com/nickberry17/packages-1/tree/shellcheck/net/modemmanager/files</a></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">A couple of questions:</div><div class=""><br class=""></div><div class="">Does this variable need to be used by another file?</div><div class=""><div class="">In modemmanager.common line 14:</div><div class="">MODEMMANAGER_PID_FILE="${MODEMMANAGER_RUNDIR}/modemmanager.pid"</div><div class="">^-- SC2034: MODEMMANAGER_PID_FILE appears unused. Verify it or export it.</div><div class=""><br class=""></div></div><div class="">Is the expected behaviour to only apply permissions on the deepest directory? 25-modemmanager-tty has the same.</div><div class=""><div class="">In 25-modemmanager-net line 12:</div><div class="">mkdir -m 0755 -p "${MODEMMANAGER_RUNDIR}"</div><div class=""> ^-- SC2174: When used with -p, -m only applies to the deepest directory.</div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Best,</div><div class="">Nick</div></body></html>