<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-2"> <style type="text/css" style="display:none"></style> </head> <body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Hello NetworkManager team, <br> I need to add new parameter called acs to libnm-core, which is required in our project, because of custom firmware.</p> <p>I will do this locally without modifying main path.<br> I use version 1.36.6 as a base.<br> This new param should be similar to </p> <div style="color: #cccccc;background-color: #1f1f1f;font-family: 'Droid Sans Mono', 'monospace', monospace;font-weight: normal;font-size: 14px;line-height: 19px;white-space: pre;"> <div><span style="color: #c586c0;">#define</span><span style="color: #569cd6;"> </span> <span style="color: #569cd6;">NM_SETTING_WIRELESS_HIDDEN</span><span style="color: #569cd6;"> </span><span style="color: #ce9178;">"hidden"</span></div> </div> <p>from src/libnm-core-public/nm-setting-wireless.h.<br> I also added getter, PROP, and define it in src/libnm-core-impl/nm-setting-wireless.c using </p> <div style="color: #cccccc;background-color: #1f1f1f;font-family: 'Droid Sans Mono', 'monospace', monospace;font-weight: normal;font-size: 14px;line-height: 19px;white-space: pre;"> <div><span style="color: #569cd6;">_nm_setting_property_define_direct_boolean</span></div> </div> <p><br> The problem I faced is when I tried to modify it or read it with nmcli c commands.<br> Then I got errors: <br> </p> <p>(process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 738 (<dropped>): should not be reached<br> (process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 47 (<dropped>): should not be reached<br> (process:17887): GLib-GObject-WARNING **: 09:17:23.837: g_object_get_is_valid_property: object class 'NMSettingWireless' has no property named 'acs'<br> <br> I suppose that something is still missing on nmcli side, but I don't have idea what it might be. <br> Could you advise how to add any new param to be changeable by nmcli?<br> <br> I provide diff file with my patch. If any other information should be provided I do this.<br> <br> Thanks for any hints and your supports.<br> <br> Best Regards, <br> Dominik<br> </p> <p><br> </p> <span style="background-color:white;" lang="pl"> <div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US"><strong>Dominik Wardzala<br> </strong></span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US">Software Engineer<br> </span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US">Harman Connected Services Poland Sp. z o.o.</span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US"> </span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;">Ogrodowa 8</span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;">91-062 Lodz, Poland</span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;">Mobile:</span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;">Email: <a href="http://dominik.wardzala3@harman.com">dominik.wardzala3@harman.com</a> <br> </span></font></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US">Web: </span></font><a href="http://www.harman.com/" target="_blank"><font size="1" face="Times New Roman,serif"><span style="font-size:8pt;" lang="en-US">www.harman.com</span></font></a></span></font></div> <div style="margin:0;"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><img data-custom="AAMkADBkZGZjNTU0LTM2OTUtNDI4Mi04MGY4LTBlMjc2M2ZjY2ZmOABGAAAAAADr1M3tn%2BKJSJE7INz8s7ieBwAUsp3m%2Bwm5QL%2BYn5bm5onzAAAAAAErAAAUsp3m%2Bwm5QL%2BYn5bm5onzAABYnifGAAABEgAQAI6yU0MC2eNCg9mRfmcjlDU%3D" alt="Harman_Email_Template" style="display: inline; margin: 5px;" class="" width="684" lang="en-GB" height="183" border="0" src="https://owa.harman.com/owa/service.svc/s/GetFileAttachment?id=AAMkADBkZGZjNTU0LTM2OTUtNDI4Mi04MGY4LTBlMjc2M2ZjY2ZmOABGAAAAAADr1M3tn%2BKJSJE7INz8s7ieBwAUsp3m%2Bwm5QL%2BYn5bm5onzAAAAAAErAAAUsp3m%2Bwm5QL%2BYn5bm5onzAABYnifGAAABEgAQAI6yU0MC2eNCg9mRfmcjlDU%3D&X-OWA-CANARY=jSHIodvMbkuRBWG7FRGmkLghXHjuXNsIeLI-Qx58OqRif3yDX8hmz_20v8b6L1JGY3INFr9mnE8."></span></font></div> </div> </span> <p><br> </p> </body> </html>