[Nice] patch for concheck
youness.alaoui at collabora.co.uk
Wed Feb 8 19:48:46 PST 2012
Thanks for the patches! I've reviewed them and they are all good.
I fixed some indentation and style issues you had in them, other than that, they
were good. I've pushed them to the repository upstream.
Thanks for your contribution!
On 02/08/2012 10:33 AM, Madaro Livio wrote:
> here is the third patch for libnice 0.1.1.
> It addresses two issues:
> 1) Calling nice_agent_remove_stream the release of a TURN allocation (lifetime=0) does not work because it doesn't contain credentials for user authentication. The server replies with an authentication error. The client closes the socket.
> The patch inserts in the message sent to the TURN server the credentials received in the previous stun response.
> 2) I think that the server reflexive candidate gather from the turn server is not valid if the socket is reliable (TCP). The patch does not add the candidate to the local candidate list if the socket is reliable.
> Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
> This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.
> nice mailing list
> nice at lists.freedesktop.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 262 bytes
Desc: OpenPGP digital signature
More information about the nice