[Nice] Minor fixes for libnice

Rohan Garg rohan16garg at gmail.com
Tue Feb 14 09:25:31 PST 2012


2 separate patches as requested.
Best
Rohan Garg



On Tue, Feb 14, 2012 at 10:38 PM, Youness Alaoui
<youness.alaoui at collabora.co.uk> wrote:
> On 02/14/2012 09:35 AM, Rohan Garg wrote:
>> Hi
>> I've found a couple of minor fixes for libnice that might lead to
>> potential issues. Patch to fix them has been attached.
>
> Hi Rohan,
>
> Since these are a couple of fixes, I'd prefer getting a couple of patches. Can
> you separate them into two patches, so I can commit them separately.
> This helps me pick what I want/need (in this case, I would have merged the first
> one).
> The first fix for the enum is correct, thanks for noticing.
> The second one, I don't like as much, I'd prefer sizeof(struct MD5Context),
> rather than sizeof(*ctx). but yeah, it's also a good fix.
>
> Thanks,
> Youness.
>
>>
>> Best
>> Rohan Garg
>>
>>
>>
>> _______________________________________________
>> nice mailing list
>> nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
>
>
>
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-the-correct-enum.patch
Type: text/x-patch
Size: 756 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nice/attachments/20120214/710426b1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-size-of-the-MD5Context-not-size-of-the-pointer.patch
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nice/attachments/20120214/710426b1/attachment-0001.bin>


More information about the nice mailing list