[Nice] UPnP mapping timeout

[Youness Alaoui]

Ok it's fixed. thanks for reporting/noticing it!
The patches are in my git repository available here :
http://cgit.collabora.com/git/user/kakaroto/libnice.git/

And here is the diff of the two patches that I needed to fix the bug :
http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=32b1b90f7aef5595829c6443f0a63ab0e492c9a3
http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=db2e674f516e8695adb3d302610bf6a15e5c0d70

Youness.

On 01/12/2012 04:14 PM, Youness Alaoui wrote:
> oh wow, first bug in a while! You're right, that's not normal and I just found
> the bug, it was a stupid logic error. I was only cancelling the upnp_timeout
> timer if there were still some pending upnp requests (was checking for the
> length of the list, and forgot to do == 0).
> I've fixed it now but i broke some unit tests, so I'm looking into what side
> effects that caused.
> 
> On 01/12/2012 06:08 AM, Eduardo Bezerra wrote:
>> I have a router with upnp support, but I got the following output when trying
>> some code that uses libnice. It seems to successfully create a port forwarding
>> rule with upnp, but then it says "timeout". Is this a problem? I attached the
>> code so that you can see it if you want (I borrowed it from a previous poster to
>> the list).
>>
>> (...)
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0: Adding UPnP port
>> 192.168.1.117:54321 <http://192.168.1.117:54321>
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : Adding new srv-rflx candidate
>> discovery 0x7fdfbfa35010
>>
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : discovery tick #1 with list
>> 0x1faef40 (1)
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : discovery - scheduling cand
>> type 1 addr 127.0.0.1.
>>
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : stream 1 component 1
>> STATE-CHANGE 0 -> 1.
>> cb_component_state_changed
>>
>> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called
>> from wrong context!
>>
>> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called
>> from wrong context!
>>
>> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called
>> from wrong context!
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : Successfully mapped
>> 192.168.1.117:54321 <http://192.168.1.117:54321> to 95.127.127.155:54321
>> <http://95.127.127.155:54321>
>> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : UPnP port mapping timed out
>> (...)
>>
>> Eduardo
>>
>>
>> _______________________________________________
>> Nice mailing list
>> Nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
> 
> 
> 
> 
> _______________________________________________
> Nice mailing list
> Nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20120112/76f675b8/attachment.pgp>