[Nice] R: R: More patches regarding mingw/msys and Visual Studio platforms

Mon Mar 12 09:16:27 PDT 2012

ouch! I always did a make check before pushing commits, I don't know how that
happened!
Thanks Rohan for the patch, I've applied it now and pushed.

On 03/12/2012 05:23 AM, Della Betta Filippo wrote:
> You're right, I thought io.h was available on Linux too
> Regards,
> Filippo Della Betta
> 
> -----Messaggio originale-----
> Da: nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.org [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.org] Per conto di Rohan Garg
> Inviato: sabato 10 marzo 2012 14:06
> A: nice at lists.freedesktop.org
> Oggetto: Re: [Nice] R: More patches regarding mingw/msys and Visual Studio platforms
> 
> Hey
> Seems like a couple of these patches broke compiles on Linux ( using clang ). If I understand this correctly, io.h is only present on Windows, and is not properly ifdef'd in the commited code, for example this : http://cgit.collabora.com/git/libnice.git/commit/?id=7736600fb22c8e1d82c354e78ce482ebfbc088e8
> 
> I've attached a patch that ifdef's all instances of io.h and makes everything compile on linux as well.
> 
> Best
> Rohan Garg
> 
> On Fri, Mar 9, 2012 at 2:54 AM, Youness Alaoui <youness.alaoui at collabora.co.uk> wrote:
>> Ok, thanks, I've merged the 3 and 5 patches.
>> To get that 0003 patch to apply, I had to do a dos2unix on the .sln, 
>> commit that, then apply yours, then do unix2dos again... because the 
>> .patch itself was in unix style, I think it may be a bug in how git generates the .patch files.
>> Anyways, I then rebased the 3 commits (dos2unix + your patch + 
>> unix2dos) into a single commit.
>> I pushed it all upstream now.
>> Thanks again.
>>
>> On 03/06/2012 04:01 AM, Della Betta Filippo wrote:
>>> 0003: I use core.autocrlf = false in my git environment since by 
>>> default git convert EOL according to platform (windows -> CRLF, unix 
>>> ->LF). Anyway you can convert libnice.sln with unix2dos as you 
>>> already did once
>>> 0005: The bug is that the size in the memcpy is incorrect and Visual 
>>> Studio told me that stack has been corrupted while doing 
>>> test-address. In particular, in function nice_address_set_from_string 
>>> of file address.c (line 190) it told me that stack is corrupted near 
>>> variable 'a' since nice_address_set_ipv6 write after the size of a; 
>>> 0007, 0004: you're welcome :) Regards, Filippo
>>>
>>>
>>> -----Messaggio originale-----
>>> Da: 
>>> nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.or
>>> g 
>>> [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freede
>>> sktop.org] Per conto di Youness Alaoui
>>> Inviato: martedì 6 marzo 2012 03:03
>>> A: nice at lists.freedesktop.org
>>> Oggetto: Re: [Nice] More patches regarding mingw/msys and Visual 
>>> Studio platforms
>>>
>>>
>>> 0003: doesn't apply for some reason, maybe a \r\n and \n issue in the patch ?
>>> 0005: Is there a reason for doing that? what bug does it fix?
>>> 0007: merged, wow that was some ugly code you removed! thanks!
>>> 0004, 6, 8, 9, 10, 11, 12: merged, thanks.
>>>
>>> Thanks again,
>>> Youness.
>>>
>>>
>>> On 03/05/2012 12:10 PM, Della Betta Filippo wrote:
>>>> Various patches addressing msys/mingw make and make check 
>>>> compilation, Visual Studio increased support/compilation.
>>>>
>>>> Regards,
>>>>
>>>> Filippo Della Betta
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> *Da:*Della Betta Filippo
>>>> *Inviato:* lunedì 5 marzo 2012 12:37
>>>> *A:* 'Youness Alaoui (youness.alaoui at collabora.co.uk)'; 'nice at lists.freedesktop.org'
>>>> *Oggetto:* patches for gsocket support and gtk-doc missing
>>>>
>>>>
>>>>
>>>> Hi,
>>>>
>>>> Attached you can find patches for
>>>>
>>>> 1)      Support for msys/mingw and Visual Studio for gsocket (added 
>>>> gio dependency), after Livio's patches
>>>>
>>>> 2)      Support for msys/mingw when gtk-doc is not installed
>>>>
>>>> Regards,
>>>>
>>>> Filippo Della Betta
>>>>
>>>>
>>>>
>>>> Questo messaggio e i suoi allegati sono indirizzati esclusivamente 
>>>> alle persone indicate. La diffusione, copia o qualsiasi altra azione 
>>>> derivante dalla conoscenza di queste informazioni sono rigorosamente 
>>>> vietate. Qualora abbiate ricevuto questo documento per errore siete 
>>>> cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
>>>>
>>>> /This e-mail and any attachments// is //confidential and may contain 
>>>> privileged information intended for the addressee(s) only.
>>>> Dissemination, copying, printing or use by anybody else is 
>>>> unauthorised. If you are not the intended recipient, please delete 
>>>> this message and any attachments and advise the sender by return 
>>>> e-mail, Thanks./
>>>>
>>>> *rispetta l'ambienteRispetta l'ambiente. Non stampare questa mail se 
>>>> non è
>>>> necessario.*
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> nice mailing list
>>>> nice at lists.freedesktop.org
>>>> http://lists.freedesktop.org/mailman/listinfo/nice
>>>
>>>
>>>
>>> Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
>>>
>>> This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.
>>>
>>
>>
>>
>> _______________________________________________
>> nice mailing list
>> nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
>>
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20120312/788ae559/attachment.pgp>